Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1610543002:
Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, (Closed)
|
Created:
4 years, 11 months ago by nisse-webrtc Modified:
4 years, 11 months ago CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDeleted unused enums MediaChannelOptions and VoiceMediaChannelOptions,
with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB.
BUG=webrtc:5426
TBR=pthatcher@webrtc.org
Committed: https://crrev.com/9de632a100d4f4cb9c0772d6106f911dcb738bf1
Cr-Commit-Position: refs/heads/master@{#11365}
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
nisse@webrtc.org changed reviewers: + pbos@webrtc.org, pthatcher@webrtc.org
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610543002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 ========== to ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 ==========
nisse@webrtc.org changed reviewers: + tommi@webrtc.org
Description was changed from ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 ========== to ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 TBR=pthatcher@webrtc.org ==========
perkj@webrtc.org changed reviewers: + perkj@webrtc.org
The CQ bit was checked by perkj@webrtc.org
lgtm I don-t know what this is. Lets remove and see if anything we dont know about breaks. pthatcher- let us know if we have to be more careful when removing unused code.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610543002/1
Message was sent while issue was closed.
Description was changed from ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 TBR=pthatcher@webrtc.org ========== to ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 TBR=pthatcher@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 TBR=pthatcher@webrtc.org ========== to ========== Deleted unused enums MediaChannelOptions and VoiceMediaChannelOptions, with constants OPT_CONFERENCE and OPT_AGC_MINUS_10DB. BUG=webrtc:5426 TBR=pthatcher@webrtc.org Committed: https://crrev.com/9de632a100d4f4cb9c0772d6106f911dcb738bf1 Cr-Commit-Position: refs/heads/master@{#11365} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9de632a100d4f4cb9c0772d6106f911dcb738bf1 Cr-Commit-Position: refs/heads/master@{#11365} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
