Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1610083002:
Deleted unused method SetDumpPath and unneeded includes. (Closed)
|
Created:
4 years, 11 months ago by nisse-webrtc Modified:
4 years, 11 months ago CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDeleted unused method SetDumpPath and unneeded includes.
BUG=webrtc:5426
Committed: https://crrev.com/0a37497842bfc344a8f39247998c641e80683f1f
Cr-Commit-Position: refs/heads/master@{#11359}
Patch Set 1 #
Messages
Total messages: 26 (13 generated)
nisse@webrtc.org changed reviewers: + magjed@webrtc.org, pbos@webrtc.org
My intention is that cricket::VideoRenderer should be made a compatibility wrapper for rtc::VideoSinkInterface, and ultimately deleted.
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610083002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610083002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2963)
Description was changed from ========== Deleted unused method SetDumpPath and unneeded includes. BUG=webrtc:5426 ========== to ========== Deleted unused method SetDumpPath and unneeded includes. BUG=webrtc:5426 ==========
nisse@webrtc.org changed reviewers: + tommi@webrtc.org
lgtm
perkj@webrtc.org changed reviewers: + perkj@webrtc.org
The CQ bit was checked by perkj@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610083002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610083002/1
Message was sent while issue was closed.
Description was changed from ========== Deleted unused method SetDumpPath and unneeded includes. BUG=webrtc:5426 ========== to ========== Deleted unused method SetDumpPath and unneeded includes. BUG=webrtc:5426 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Deleted unused method SetDumpPath and unneeded includes. BUG=webrtc:5426 ========== to ========== Deleted unused method SetDumpPath and unneeded includes. BUG=webrtc:5426 Committed: https://crrev.com/0a37497842bfc344a8f39247998c641e80683f1f Cr-Commit-Position: refs/heads/master@{#11359} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0a37497842bfc344a8f39247998c641e80683f1f Cr-Commit-Position: refs/heads/master@{#11359} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
