Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1610073003: Switch CriticalSectionWrapper->rtc::CriticalSection in modules/audio_coding. (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Switch CriticalSectionWrapper->rtc::CriticalSection in modules/audio_coding. This is a part of cleaning up CriticalSectionWrapper in general. BUG= R=henrik.lundin@webrtc.org Committed: https://crrev.com/9090e0b1477f2f183abaf381c457d65435cd749c Cr-Commit-Position: refs/heads/master@{#11319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -132 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 13 chunks +13 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 4 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 25 chunks +25 lines, -28 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 16 chunks +20 lines, -23 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 20 chunks +28 lines, -30 lines 0 comments Download
M webrtc/modules/audio_coding/test/Channel.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/Channel.cc View 12 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tommi
4 years, 11 months ago (2016-01-20 09:58:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610073003/1
4 years, 11 months ago (2016-01-20 09:58:51 UTC) #4
hlundin-webrtc
lgtm, thanks for fixing.
4 years, 11 months ago (2016-01-20 11:34:57 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
4 years, 11 months ago (2016-01-20 11:59:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610073003/1
4 years, 11 months ago (2016-01-20 12:31:59 UTC) #9
tommi
Committed patchset #1 (id:1) manually as 9090e0b1477f2f183abaf381c457d65435cd749c (presubmit successful).
4 years, 11 months ago (2016-01-20 12:39:51 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 12:39:52 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9090e0b1477f2f183abaf381c457d65435cd749c
Cr-Commit-Position: refs/heads/master@{#11319}

Powered by Google App Engine
This is Rietveld 408576698