Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1609563003: Remove two dead 'using' instances. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove two dead 'using' instances. BUG= TBR=pthatcher@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/8d6fab8facca5b6ed29359322f83edb27b075ad7 Cr-Commit-Position: refs/heads/master@{#11296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL, found using a dead-code analysis tool that probably wasn't too effective at finding dead ...
4 years, 11 months ago (2016-01-18 23:24:18 UTC) #1
pbos-webrtc
Committed patchset #1 (id:1) manually as 8d6fab8facca5b6ed29359322f83edb27b075ad7 (presubmit successful).
4 years, 11 months ago (2016-01-18 23:24:42 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d6fab8facca5b6ed29359322f83edb27b075ad7 Cr-Commit-Position: refs/heads/master@{#11296}
4 years, 11 months ago (2016-01-18 23:24:46 UTC) #5
stefan-webrtc
4 years, 11 months ago (2016-01-19 12:03:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698