Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1608813002: Fix parsing of CLANG_REVISON from tools/clang/scripts/update.py (Closed)

Created:
4 years, 11 months ago by kjellander_webrtc
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix parsing of CLANG_REVISON from tools/clang/scripts/update.py The regex didn't match the revision before after the switch from tools/clang/scripts/update.sh to tools/clang/scripts/update.py. This should have been done in https://codereview.webrtc.org/1493683003 when the filename changed. TESTED=Ran the script and verified parsing worked and showed the currently pending Clang change in ongoing roll in https://codereview.webrtc.org/1593713013/ NOTRY=True Committed: https://crrev.com/3860c7f8731c4718f40a762cffb65f12dc294a69 Cr-Commit-Position: refs/heads/master@{#11299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/autoroller/roll_chromium_revision.py View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
4 years, 11 months ago (2016-01-19 06:58:08 UTC) #3
pbos-webrtc
lgtm, thanks for raising a RollError if it fails as well.
4 years, 11 months ago (2016-01-19 09:48:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608813002/1
4 years, 11 months ago (2016-01-19 10:00:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 10:04:45 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 10:04:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3860c7f8731c4718f40a762cffb65f12dc294a69
Cr-Commit-Position: refs/heads/master@{#11299}

Powered by Google App Engine
This is Rietveld 408576698