Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608743005: Switch to rtc::CriticalSection in IncomingVideoStream and remove one lock. (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Switch to rtc::CriticalSection in IncomingVideoStream and remove one lock. BUG= Committed: https://crrev.com/84df580d52e19c7ebe8533d643501fdba7c8e093 Cr-Commit-Position: refs/heads/master@{#11318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M webrtc/common_video/include/incoming_video_stream.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 11 chunks +17 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tommi
4 years, 11 months ago (2016-01-20 09:35:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608743005/1
4 years, 11 months ago (2016-01-20 09:35:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 10:42:42 UTC) #6
pbos-webrtc
lgtm, thanks
4 years, 11 months ago (2016-01-20 11:49:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608743005/1
4 years, 11 months ago (2016-01-20 12:33:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 12:37:58 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 12:38:08 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/84df580d52e19c7ebe8533d643501fdba7c8e093
Cr-Commit-Position: refs/heads/master@{#11318}

Powered by Google App Engine
This is Rietveld 408576698