Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1608563005: Enable transport seq num extension on receive channel to suppress log warning. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
the sun, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable transport seq num extension on receive channel to suppress log warning. TBR=pbos@webrtc.org BUG=webrtc:5263 Committed: https://crrev.com/3313ec901f066d879aa5889ab38588a3612fe28d Cr-Commit-Position: refs/heads/master@{#11338}

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 4

Patch Set 3 : Comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 2 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
stefan-webrtc
Add test.
4 years, 11 months ago (2016-01-19 14:42:49 UTC) #1
stefan-webrtc
4 years, 11 months ago (2016-01-20 08:46:10 UTC) #3
the sun
lgtm % nits https://codereview.webrtc.org/1608563005/diff/20001/webrtc/audio/audio_receive_stream_unittest.cc File webrtc/audio/audio_receive_stream_unittest.cc (right): https://codereview.webrtc.org/1608563005/diff/20001/webrtc/audio/audio_receive_stream_unittest.cc#newcode12 webrtc/audio/audio_receive_stream_unittest.cc:12: #include <vector> lint warning? https://codereview.webrtc.org/1608563005/diff/20001/webrtc/test/mock_voe_channel_proxy.h File ...
4 years, 11 months ago (2016-01-21 12:24:52 UTC) #4
stefan-webrtc
Comments addressed.
4 years, 11 months ago (2016-01-21 13:17:29 UTC) #5
stefan-webrtc
https://codereview.webrtc.org/1608563005/diff/20001/webrtc/audio/audio_receive_stream_unittest.cc File webrtc/audio/audio_receive_stream_unittest.cc (right): https://codereview.webrtc.org/1608563005/diff/20001/webrtc/audio/audio_receive_stream_unittest.cc#newcode12 webrtc/audio/audio_receive_stream_unittest.cc:12: #include <vector> On 2016/01/21 12:24:52, the sun wrote: > ...
4 years, 11 months ago (2016-01-21 13:17:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608563005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608563005/40001
4 years, 11 months ago (2016-01-21 13:19:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2995)
4 years, 11 months ago (2016-01-21 13:39:00 UTC) #11
stefan-webrtc
pbos, ptal webrtc/test/ after the fact.
4 years, 11 months ago (2016-01-21 13:41:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608563005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608563005/40001
4 years, 11 months ago (2016-01-21 13:42:15 UTC) #16
pbos-webrtc
lgtm for webrtc/test, will add stefan@ to test/ OWNERS
4 years, 11 months ago (2016-01-21 14:06:54 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-21 14:32:48 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 14:32:55 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3313ec901f066d879aa5889ab38588a3612fe28d
Cr-Commit-Position: refs/heads/master@{#11338}

Powered by Google App Engine
This is Rietveld 408576698