Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: webrtc/modules/audio_coding/audio_coding.gypi

Issue 1607463002: Declare that rent_a_codec depends on the audio codecs (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: gn refactoring Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_coding.gypi
diff --git a/webrtc/modules/audio_coding/audio_coding.gypi b/webrtc/modules/audio_coding/audio_coding.gypi
index d64fbeee292abd00b540596cb9e84ab6d70ad548..e460853ac10b4b9fbc84bedb4c3a95966dac35ac 100644
--- a/webrtc/modules/audio_coding/audio_coding.gypi
+++ b/webrtc/modules/audio_coding/audio_coding.gypi
@@ -22,52 +22,61 @@
'neteq/neteq.gypi',
],
'variables': {
+ 'variables': {
+ 'audio_codec_dependencies': [
+ 'cng',
+ 'g711',
+ 'pcm16b',
+ ],
+ 'audio_codec_defines': [],
+ 'conditions': [
+ ['include_ilbc==1', {
+ 'audio_codec_dependencies': ['ilbc',],
+ 'audio_codec_defines': ['WEBRTC_CODEC_ILBC',],
+ }],
+ ['include_opus==1', {
+ 'audio_codec_dependencies': ['webrtc_opus',],
+ 'audio_codec_defines': ['WEBRTC_CODEC_OPUS',],
+ }],
+ ['build_with_mozilla==0', {
+ 'conditions': [
+ ['target_arch=="arm"', {
+ 'audio_codec_dependencies': ['isac_fix',],
+ 'audio_codec_defines': ['WEBRTC_CODEC_ISACFX',],
+ }, {
+ 'audio_codec_dependencies': ['isac',],
+ 'audio_codec_defines': ['WEBRTC_CODEC_ISAC',],
+ }],
+ ],
+ 'audio_codec_dependencies': ['g722',],
+ 'audio_codec_defines': ['WEBRTC_CODEC_G722',],
+ }],
+ ['build_with_mozilla==0 and build_with_chromium==0', {
+ 'audio_codec_dependencies': ['red',],
+ 'audio_codec_defines': ['WEBRTC_CODEC_RED',],
+ }],
+ ],
+ },
+ 'audio_codec_dependencies': '<(audio_codec_dependencies)',
+ 'audio_codec_defines': '<(audio_codec_defines)',
'audio_coding_dependencies': [
- 'cng',
- 'g711',
- 'pcm16b',
+ '<@(audio_codec_dependencies)',
'<(webrtc_root)/common.gyp:webrtc_common',
'<(webrtc_root)/common_audio/common_audio.gyp:common_audio',
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers',
],
- 'audio_coding_defines': [],
- 'conditions': [
- ['include_ilbc==1', {
- 'audio_coding_dependencies': ['ilbc',],
- 'audio_coding_defines': ['WEBRTC_CODEC_ILBC',],
- }],
- ['include_opus==1', {
- 'audio_coding_dependencies': ['webrtc_opus',],
- 'audio_coding_defines': ['WEBRTC_CODEC_OPUS',],
- }],
- ['build_with_mozilla==0', {
- 'conditions': [
- ['target_arch=="arm"', {
- 'audio_coding_dependencies': ['isac_fix',],
- 'audio_coding_defines': ['WEBRTC_CODEC_ISACFX',],
- }, {
- 'audio_coding_dependencies': ['isac',],
- 'audio_coding_defines': ['WEBRTC_CODEC_ISAC',],
- }],
- ],
- 'audio_coding_dependencies': ['g722',],
- 'audio_coding_defines': ['WEBRTC_CODEC_G722',],
- }],
- ['build_with_mozilla==0 and build_with_chromium==0', {
- 'audio_coding_dependencies': ['red',],
- 'audio_coding_defines': ['WEBRTC_CODEC_RED',],
- }],
- ],
+ 'audio_coding_defines': '<(audio_codec_defines)',
},
'targets': [
{
'target_name': 'rent_a_codec',
'type': 'static_library',
'defines': [
- '<@(audio_coding_defines)',
+ '<@(audio_codec_defines)',
],
'dependencies': [
'<(webrtc_root)/common.gyp:webrtc_common',
+ '<@(audio_codec_dependencies)',
],
'include_dirs': [
'<(webrtc_root)',
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/audio_coding/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698