Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc

Issue 1607353002: Swap use of CriticalSectionWrapper with rtc::CriticalSection in voice_engine/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix bug in monitor_module.cc Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc
diff --git a/webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc b/webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc
index 6efa55d516bdd1730c5b44cd20eca8bd1f75f7bd..d653cc129716dde6790f1fb044a8bd9d10b65440 100644
--- a/webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc
+++ b/webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc
@@ -8,8 +8,8 @@
* be found in the AUTHORS file in the root of the source tree.
*/
+#include "webrtc/base/criticalsection.h"
#include "webrtc/system_wrappers/include/atomic32.h"
-#include "webrtc/system_wrappers/include/critical_section_wrapper.h"
#include "webrtc/system_wrappers/include/event_wrapper.h"
#include "webrtc/test/testsupport/fileutils.h"
#include "webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h"
@@ -17,9 +17,7 @@
class TestRtpObserver : public webrtc::VoERTPObserver {
public:
- TestRtpObserver()
- : crit_(voetest::CriticalSectionWrapper::CreateCriticalSection()),
- changed_ssrc_event_(voetest::EventWrapper::Create()) {}
+ TestRtpObserver() : changed_ssrc_event_(voetest::EventWrapper::Create()) {}
virtual ~TestRtpObserver() {}
virtual void OnIncomingCSRCChanged(int channel,
unsigned int CSRC,
@@ -31,11 +29,11 @@ class TestRtpObserver : public webrtc::VoERTPObserver {
EXPECT_EQ(voetest::kEventSignaled, changed_ssrc_event_->Wait(10*1000));
}
void SetIncomingSsrc(unsigned int ssrc) {
- voetest::CriticalSectionScoped lock(crit_.get());
+ rtc::CritScope lock(&crit_);
incoming_ssrc_ = ssrc;
}
public:
- rtc::scoped_ptr<voetest::CriticalSectionWrapper> crit_;
+ rtc::CriticalSection crit_;
unsigned int incoming_ssrc_;
rtc::scoped_ptr<voetest::EventWrapper> changed_ssrc_event_;
};
@@ -48,7 +46,7 @@ void TestRtpObserver::OnIncomingSSRCChanged(int channel,
TEST_LOG("%s", msg);
{
- voetest::CriticalSectionScoped lock(crit_.get());
+ rtc::CritScope lock(&crit_);
if (incoming_ssrc_ == SSRC)
changed_ssrc_event_->Set();
}

Powered by Google App Engine
This is Rietveld 408576698