Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: webrtc/voice_engine/monitor_module.h

Issue 1607353002: Swap use of CriticalSectionWrapper with rtc::CriticalSection in voice_engine/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/monitor_module.h
diff --git a/webrtc/voice_engine/monitor_module.h b/webrtc/voice_engine/monitor_module.h
index fe915b320b3df972a461918a25fdf7937371a70f..9c413105d8baf9df5b1807806212b2d4b24279ed 100644
--- a/webrtc/voice_engine/monitor_module.h
+++ b/webrtc/voice_engine/monitor_module.h
@@ -11,6 +11,7 @@
#ifndef WEBRTC_VOICE_ENGINE_MONITOR_MODULE_H
#define WEBRTC_VOICE_ENGINE_MONITOR_MODULE_H
+#include "webrtc/base/criticalsection.h"
#include "webrtc/modules/include/module.h"
#include "webrtc/typedefs.h"
#include "webrtc/voice_engine/voice_engine_defines.h"
@@ -25,8 +26,6 @@ protected:
namespace webrtc {
-class CriticalSectionWrapper;
-
namespace voe {
class MonitorModule : public Module
@@ -46,7 +45,7 @@ public: // module
private:
MonitorObserver* _observerPtr;
- CriticalSectionWrapper& _callbackCritSect;
+ mutable rtc::CriticalSection _callbackCritSect;
the sun 2016/01/21 13:07:28 nits: remove mutable, add GUARDED_BY to _observerP
tommi 2016/01/21 15:29:23 Done.
tommi 2016/01/21 15:37:15 Oh and that nit uncovered a bug in the code! Nice.
the sun 2016/01/21 19:28:45 How about that! :)
int64_t _lastProcessTime;
};

Powered by Google App Engine
This is Rietveld 408576698