Chromium Code Reviews

Side by Side Diff: webrtc/voice_engine/voe_dtmf_impl.cc

Issue 1607353002: Swap use of CriticalSectionWrapper with rtc::CriticalSection in voice_engine/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/voice_engine/voe_dtmf_impl.h" 11 #include "webrtc/voice_engine/voe_dtmf_impl.h"
12 12
13 #include "webrtc/system_wrappers/include/critical_section_wrapper.h"
14 #include "webrtc/system_wrappers/include/trace.h" 13 #include "webrtc/system_wrappers/include/trace.h"
15 #include "webrtc/voice_engine/channel.h" 14 #include "webrtc/voice_engine/channel.h"
16 #include "webrtc/voice_engine/include/voe_errors.h" 15 #include "webrtc/voice_engine/include/voe_errors.h"
17 #include "webrtc/voice_engine/output_mixer.h" 16 #include "webrtc/voice_engine/output_mixer.h"
18 #include "webrtc/voice_engine/transmit_mixer.h" 17 #include "webrtc/voice_engine/transmit_mixer.h"
19 #include "webrtc/voice_engine/voice_engine_impl.h" 18 #include "webrtc/voice_engine/voice_engine_impl.h"
20 19
21 namespace webrtc { 20 namespace webrtc {
22 21
23 VoEDtmf* VoEDtmf::GetInterface(VoiceEngine* voiceEngine) { 22 VoEDtmf* VoEDtmf::GetInterface(VoiceEngine* voiceEngine) {
(...skipping 166 matching lines...)
190 } 189 }
191 return _shared->output_mixer()->PlayDtmfTone(eventCode, lengthMs, 190 return _shared->output_mixer()->PlayDtmfTone(eventCode, lengthMs,
192 attenuationDb); 191 attenuationDb);
193 } 192 }
194 193
195 int VoEDtmfImpl::SetDtmfFeedbackStatus(bool enable, bool directFeedback) { 194 int VoEDtmfImpl::SetDtmfFeedbackStatus(bool enable, bool directFeedback) {
196 WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1), 195 WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
197 "SetDtmfFeedbackStatus(enable=%d, directFeeback=%d)", 196 "SetDtmfFeedbackStatus(enable=%d, directFeeback=%d)",
198 (int)enable, (int)directFeedback); 197 (int)enable, (int)directFeedback);
199 198
200 CriticalSectionScoped sc(_shared->crit_sec()); 199 rtc::CritScope cs(_shared->crit_sec());
the sun 2016/01/21 13:07:28 nit: transitive dependency? Include-what-you-use?
tommi 2016/01/21 15:29:23 Done.
201 200
202 _dtmfFeedback = enable; 201 _dtmfFeedback = enable;
203 _dtmfDirectFeedback = directFeedback; 202 _dtmfDirectFeedback = directFeedback;
204 203
205 return 0; 204 return 0;
206 } 205 }
207 206
208 int VoEDtmfImpl::GetDtmfFeedbackStatus(bool& enabled, bool& directFeedback) { 207 int VoEDtmfImpl::GetDtmfFeedbackStatus(bool& enabled, bool& directFeedback) {
209 CriticalSectionScoped sc(_shared->crit_sec()); 208 rtc::CritScope cs(_shared->crit_sec());
210 209
211 enabled = _dtmfFeedback; 210 enabled = _dtmfFeedback;
212 directFeedback = _dtmfDirectFeedback; 211 directFeedback = _dtmfDirectFeedback;
213 return 0; 212 return 0;
214 } 213 }
215 #endif // #ifdef WEBRTC_VOICE_ENGINE_DTMF_API 214 #endif // #ifdef WEBRTC_VOICE_ENGINE_DTMF_API
216 215
217 } // namespace webrtc 216 } // namespace webrtc
OLDNEW

Powered by Google App Engine