Remove use of ConditionVariableWrapper and CriticalSectionWrapper from UdpSocket2Windows.

Remove use of ConditionVariableWrapper and CriticalSectionWrapper from UdpSocket2Windows.
This helps with untangling CriticalSectionWrapper from ConditionVariableWrapper and looks like we can just delete ConditionVariableWrapper and use rtc::Event instead.

BUG=
R=pbos@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/f01ea4f847380ede23131412d8f730da7c33244c

[tommi, 2016-01-19 17:13:33]

Remove criticalsection header

[tommi, 2016-01-19 17:13:52]

tommi@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-01-19 20:36:51]

https://codereview.webrtc.org/1606993002/diff/20001/webrtc/test/channel_trans...
File webrtc/test/channel_transport/udp_socket2_win.cc (right):

https://codereview.webrtc.org/1606993002/diff/20001/webrtc/test/channel_trans...
webrtc/test/channel_transport/udp_socket2_win.cc:1304: if (!_safeTodelete)
Racy read, this was protected by the critical section. Use atomics to set/get
this.

[pbos-webrtc, 2016-01-19 20:41:09]

lgtm with proposed fix (removed _safeToDelete)

https://codereview.webrtc.org/1606993002/diff/20001/webrtc/test/channel_trans...
File webrtc/test/channel_transport/udp_socket2_win.cc (right):

https://codereview.webrtc.org/1606993002/diff/20001/webrtc/test/channel_trans...
webrtc/test/channel_transport/udp_socket2_win.cc:1304: if (!_safeTodelete)
OTOH, just remove this variable, the event is still set, you can Wait() for it
always.

[tommi, 2016-01-19 21:06:13]

Remove unnecessary variable

[tommi, 2016-01-19 21:06:25]

https://codereview.webrtc.org/1606993002/diff/20001/webrtc/test/channel_trans...
File webrtc/test/channel_transport/udp_socket2_win.cc (right):

https://codereview.webrtc.org/1606993002/diff/20001/webrtc/test/channel_trans...
webrtc/test/channel_transport/udp_socket2_win.cc:1304: if (!_safeTodelete)
On 2016/01/19 20:41:09, pbos-webrtc wrote:
> OTOH, just remove this variable, the event is still set, you can Wait() for it
> always.

Yes, will do.
This code is riddled with races though :-(  WaitForOutstandingCalls() is also an
enigma.  It's called just before 'delete this', the first thing in the dtor as
well and it's just two lines of code.  I'm not sure what the thought was behind
this.  Before, the code would enter a loop too even though the code that called
Wake(), would always set this variable.

[tommi, 2016-01-19 21:06:32]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-01-19 21:06:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1606993002/#ps40001 (title:
"Remove unnecessary variable")

[commit-bot: I haz the power, 2016-01-19 21:06:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606993002/40001

[commit-bot: I haz the power, 2016-01-19 21:50:08]

Description was changed from

==========
Remove use of ConditionVariableWrapper and CriticalSectionWrapper from
UdpSocket2Windows.
This helps with untangling CriticalSectionWrapper from ConditionVariableWrapper
and looks like we can just delete ConditionVariableWrapper and use rtc::Event
instead.

BUG=
==========

to

==========
Remove use of ConditionVariableWrapper and CriticalSectionWrapper from
UdpSocket2Windows.
This helps with untangling CriticalSectionWrapper from ConditionVariableWrapper
and looks like we can just delete ConditionVariableWrapper and use rtc::Event
instead.

BUG=
R=pbos@webrtc.org

Committed: https://crrev.com/f01ea4f847380ede23131412d8f730da7c33244c
Cr-Commit-Position: refs/heads/master@{#11309}
==========

[commit-bot: I haz the power, 2016-01-19 21:50:09]

Patchset 3 (id:??) landed as
https://crrev.com/f01ea4f847380ede23131412d8f730da7c33244c
Cr-Commit-Position: refs/heads/master@{#11309}

[tommi, 2016-01-19 21:50:09]

Description was changed from

==========
Remove use of ConditionVariableWrapper and CriticalSectionWrapper from
UdpSocket2Windows.
This helps with untangling CriticalSectionWrapper from ConditionVariableWrapper
and looks like we can just delete ConditionVariableWrapper and use rtc::Event
instead.

BUG=
R=pbos@webrtc.org

Committed: https://crrev.com/f01ea4f847380ede23131412d8f730da7c33244c
Cr-Commit-Position: refs/heads/master@{#11309}
==========

to

==========
Remove use of ConditionVariableWrapper and CriticalSectionWrapper from
UdpSocket2Windows.
This helps with untangling CriticalSectionWrapper from ConditionVariableWrapper
and looks like we can just delete ConditionVariableWrapper and use rtc::Event
instead.

BUG=
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f01ea4f847380ede23131412d...
==========

[tommi, 2016-01-19 21:50:11]

Committed patchset #3 (id:40001) manually as
f01ea4f847380ede23131412d8f730da7c33244c (presubmit successful).