Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/temporal_layers.h

Issue 1606613003: Remove extra_options from VideoCodec. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: compile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
diff --git a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
index 47112c64aa5ecc2892952b74b0c38af8959e8dc9..0d09839a8c4e822aae4135c2bf1751a139a2844e 100644
--- a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
+++ b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
@@ -14,7 +14,6 @@
#include "vpx/vpx_encoder.h"
-#include "webrtc/common.h"
#include "webrtc/common_video/include/video_image.h"
#include "webrtc/typedefs.h"
@@ -26,15 +25,6 @@ class TemporalLayers {
public:
// Factory for TemporalLayer strategy. Default behaviour is a fixed pattern
// of temporal layers. See default_temporal_layers.cc
- struct Factory {
- Factory() {}
- virtual ~Factory() {}
- virtual TemporalLayers* Create(int temporal_layers,
- uint8_t initial_tl0_pic_idx) const;
- static const ConfigOptionID identifier =
- ConfigOptionID::kTemporalLayersFactory;
- };
-
virtual ~TemporalLayers() {}
// Returns the recommended VP8 encode flags needed. May refresh the decoder
@@ -57,13 +47,21 @@ class TemporalLayers {
virtual bool UpdateConfiguration(vpx_codec_enc_cfg_t* cfg) = 0;
};
+class TemporalLayersFactory {
+ public:
+ virtual ~TemporalLayersFactory() {}
+ virtual TemporalLayers* Create(int temporal_layers,
+ uint8_t initial_tl0_pic_idx) const;
+};
+
// Factory for a temporal layers strategy that adaptively changes the number of
// layers based on input framerate so that the base layer has an acceptable
// framerate. See realtime_temporal_layers.cc
-struct RealTimeTemporalLayersFactory : TemporalLayers::Factory {
- virtual ~RealTimeTemporalLayersFactory() {}
- virtual TemporalLayers* Create(int num_temporal_layers,
- uint8_t initial_tl0_pic_idx) const;
+class RealTimeTemporalLayersFactory : public TemporalLayersFactory {
+ public:
+ ~RealTimeTemporalLayersFactory() override {}
+ TemporalLayers* Create(int num_temporal_layers,
+ uint8_t initial_tl0_pic_idx) const override;
};
} // namespace webrtc
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h ('k') | webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698