Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1606413002: Add tracing to VCMGenericEncoder::Release. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add tracing to VCMGenericEncoder::Release. This call can take time, especially on mobile HW encoders. Make sure it shows up in tracing. BUG=webrtc:5167 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4fd6cda06796e650d1ff65edf5dd08f3f1ae3223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/video_coding/generic_encoder.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
Hardest CL of your life. PTAL.
4 years, 11 months ago (2016-01-20 20:30:10 UTC) #1
stefan-webrtc
lgtm
4 years, 11 months ago (2016-01-21 17:24:21 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fd6cda06796e650d1ff65edf5dd08f3f1ae3223 Cr-Commit-Position: refs/heads/master@{#11374}
4 years, 11 months ago (2016-01-26 09:20:07 UTC) #5
pbos-webrtc
4 years, 11 months ago (2016-01-26 09:20:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4fd6cda06796e650d1ff65edf5dd08f3f1ae3223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698