Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: webrtc/video/video_loopback.cc

Issue 1606183002: Allow packets to be reordered in the fake network pipe. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: uint8_t[] instead of uint8_t Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 "", 169 "",
170 "Comma separated values describing SpatialLayer for layer #1."); 170 "Comma separated values describing SpatialLayer for layer #1.");
171 std::string SL1() { 171 std::string SL1() {
172 return static_cast<std::string>(FLAGS_sl1); 172 return static_cast<std::string>(FLAGS_sl1);
173 } 173 }
174 174
175 DEFINE_bool(logs, false, "print logs to stderr"); 175 DEFINE_bool(logs, false, "print logs to stderr");
176 176
177 DEFINE_bool(send_side_bwe, true, "Use send-side bandwidth estimation"); 177 DEFINE_bool(send_side_bwe, true, "Use send-side bandwidth estimation");
178 178
179 DEFINE_bool(allow_reordering, false, "Allow packet reordering to occur");
180
179 DEFINE_string( 181 DEFINE_string(
180 force_fieldtrials, 182 force_fieldtrials,
181 "", 183 "",
182 "Field trials control experimental feature code which can be forced. " 184 "Field trials control experimental feature code which can be forced. "
183 "E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enable/" 185 "E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enable/"
184 " will assign the group Enable to field trial WebRTC-FooFeature. Multiple " 186 " will assign the group Enable to field trial WebRTC-FooFeature. Multiple "
185 "trials are separated by \"/\""); 187 "trials are separated by \"/\"");
186 188
187 // Video-specific flags. 189 // Video-specific flags.
188 DEFINE_string(clip, 190 DEFINE_string(clip,
189 "", 191 "",
190 "Name of the clip to show. If empty, using chroma generator."); 192 "Name of the clip to show. If empty, using chroma generator.");
191 std::string Clip() { 193 std::string Clip() {
192 return static_cast<std::string>(FLAGS_clip); 194 return static_cast<std::string>(FLAGS_clip);
193 } 195 }
194 196
195 } // namespace flags 197 } // namespace flags
196 198
197 void Loopback() { 199 void Loopback() {
198 FakeNetworkPipe::Config pipe_config; 200 FakeNetworkPipe::Config pipe_config;
199 pipe_config.loss_percent = flags::LossPercent(); 201 pipe_config.loss_percent = flags::LossPercent();
200 pipe_config.link_capacity_kbps = flags::LinkCapacityKbps(); 202 pipe_config.link_capacity_kbps = flags::LinkCapacityKbps();
201 pipe_config.queue_length_packets = flags::QueueSize(); 203 pipe_config.queue_length_packets = flags::QueueSize();
202 pipe_config.queue_delay_ms = flags::AvgPropagationDelayMs(); 204 pipe_config.queue_delay_ms = flags::AvgPropagationDelayMs();
203 pipe_config.delay_standard_deviation_ms = flags::StdPropagationDelayMs(); 205 pipe_config.delay_standard_deviation_ms = flags::StdPropagationDelayMs();
206 pipe_config.allow_reordering = flags::FLAGS_allow_reordering;
204 207
205 Call::Config::BitrateConfig call_bitrate_config; 208 Call::Config::BitrateConfig call_bitrate_config;
206 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000; 209 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000;
207 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000; 210 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000;
208 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000; 211 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
209 212
210 VideoQualityTest::Params params{ 213 VideoQualityTest::Params params{
211 {flags::Width(), flags::Height(), flags::Fps(), 214 {flags::Width(), flags::Height(), flags::Fps(),
212 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000, 215 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000,
213 flags::MaxBitrateKbps() * 1000, flags::Codec(), 216 flags::MaxBitrateKbps() * 1000, flags::Codec(),
(...skipping 27 matching lines...) Expand all
241 } // namespace webrtc 244 } // namespace webrtc
242 245
243 int main(int argc, char* argv[]) { 246 int main(int argc, char* argv[]) {
244 ::testing::InitGoogleTest(&argc, argv); 247 ::testing::InitGoogleTest(&argc, argv);
245 google::ParseCommandLineFlags(&argc, &argv, true); 248 google::ParseCommandLineFlags(&argc, &argv, true);
246 webrtc::test::InitFieldTrialsFromString( 249 webrtc::test::InitFieldTrialsFromString(
247 webrtc::flags::FLAGS_force_fieldtrials); 250 webrtc::flags::FLAGS_force_fieldtrials);
248 webrtc::test::RunTest(webrtc::Loopback); 251 webrtc::test::RunTest(webrtc::Loopback);
249 return 0; 252 return 0;
250 } 253 }
OLDNEW
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698