Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: webrtc/video/screenshare_loopback.cc

Issue 1606183002: Allow packets to be reordered in the fake network pipe. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: uint8_t[] instead of uint8_t Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/test/fake_network_pipe_unittest.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 "", 167 "",
168 "Comma separated values describing SpatialLayer for layer #1."); 168 "Comma separated values describing SpatialLayer for layer #1.");
169 std::string SL1() { 169 std::string SL1() {
170 return static_cast<std::string>(FLAGS_sl1); 170 return static_cast<std::string>(FLAGS_sl1);
171 } 171 }
172 172
173 DEFINE_bool(logs, false, "print logs to stderr"); 173 DEFINE_bool(logs, false, "print logs to stderr");
174 174
175 DEFINE_bool(send_side_bwe, true, "Use send-side bandwidth estimation"); 175 DEFINE_bool(send_side_bwe, true, "Use send-side bandwidth estimation");
176 176
177 DEFINE_bool(allow_reordering, false, "Allow packet reordering to occur");
178
177 DEFINE_string( 179 DEFINE_string(
178 force_fieldtrials, 180 force_fieldtrials,
179 "", 181 "",
180 "Field trials control experimental feature code which can be forced. " 182 "Field trials control experimental feature code which can be forced. "
181 "E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enable/" 183 "E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enable/"
182 " will assign the group Enable to field trial WebRTC-FooFeature. Multiple " 184 " will assign the group Enable to field trial WebRTC-FooFeature. Multiple "
183 "trials are separated by \"/\""); 185 "trials are separated by \"/\"");
184 186
185 // Screenshare-specific flags. 187 // Screenshare-specific flags.
186 DEFINE_int32(min_transmit_bitrate, 400, "Min transmit bitrate incl. padding."); 188 DEFINE_int32(min_transmit_bitrate, 400, "Min transmit bitrate incl. padding.");
(...skipping 18 matching lines...) Expand all
205 207
206 } // namespace flags 208 } // namespace flags
207 209
208 void Loopback() { 210 void Loopback() {
209 FakeNetworkPipe::Config pipe_config; 211 FakeNetworkPipe::Config pipe_config;
210 pipe_config.loss_percent = flags::LossPercent(); 212 pipe_config.loss_percent = flags::LossPercent();
211 pipe_config.link_capacity_kbps = flags::LinkCapacityKbps(); 213 pipe_config.link_capacity_kbps = flags::LinkCapacityKbps();
212 pipe_config.queue_length_packets = flags::QueueSize(); 214 pipe_config.queue_length_packets = flags::QueueSize();
213 pipe_config.queue_delay_ms = flags::AvgPropagationDelayMs(); 215 pipe_config.queue_delay_ms = flags::AvgPropagationDelayMs();
214 pipe_config.delay_standard_deviation_ms = flags::StdPropagationDelayMs(); 216 pipe_config.delay_standard_deviation_ms = flags::StdPropagationDelayMs();
217 pipe_config.allow_reordering = flags::FLAGS_allow_reordering;
215 218
216 Call::Config::BitrateConfig call_bitrate_config; 219 Call::Config::BitrateConfig call_bitrate_config;
217 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000; 220 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000;
218 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000; 221 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000;
219 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000; 222 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
220 223
221 VideoQualityTest::Params params{ 224 VideoQualityTest::Params params{
222 {flags::Width(), flags::Height(), flags::Fps(), 225 {flags::Width(), flags::Height(), flags::Fps(),
223 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000, 226 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000,
224 flags::MaxBitrateKbps() * 1000, flags::Codec(), 227 flags::MaxBitrateKbps() * 1000, flags::Codec(),
(...skipping 27 matching lines...) Expand all
252 } // namespace webrtc 255 } // namespace webrtc
253 256
254 int main(int argc, char* argv[]) { 257 int main(int argc, char* argv[]) {
255 ::testing::InitGoogleTest(&argc, argv); 258 ::testing::InitGoogleTest(&argc, argv);
256 google::ParseCommandLineFlags(&argc, &argv, true); 259 google::ParseCommandLineFlags(&argc, &argv, true);
257 webrtc::test::InitFieldTrialsFromString( 260 webrtc::test::InitFieldTrialsFromString(
258 webrtc::flags::FLAGS_force_fieldtrials); 261 webrtc::flags::FLAGS_force_fieldtrials);
259 webrtc::test::RunTest(webrtc::Loopback); 262 webrtc::test::RunTest(webrtc::Loopback);
260 return 0; 263 return 0;
261 } 264 }
OLDNEW
« no previous file with comments | « webrtc/test/fake_network_pipe_unittest.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698