Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: talk/media/base/codec.cc

Issue 1604563002: Add send-side BWE to WebRtcVoiceEngine under a finch experiment. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed one more comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/media/base/codec.h ('k') | talk/media/webrtc/webrtcvoiceengine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 DataCodec::DataCodec(const DataCodec& c) = default; 319 DataCodec::DataCodec(const DataCodec& c) = default;
320 320
321 DataCodec& DataCodec::operator=(const DataCodec& c) = default; 321 DataCodec& DataCodec::operator=(const DataCodec& c) = default;
322 322
323 std::string DataCodec::ToString() const { 323 std::string DataCodec::ToString() const {
324 std::ostringstream os; 324 std::ostringstream os;
325 os << "DataCodec[" << id << ":" << name << "]"; 325 os << "DataCodec[" << id << ":" << name << "]";
326 return os.str(); 326 return os.str();
327 } 327 }
328 328
329 bool HasNack(const VideoCodec& codec) { 329 bool HasNack(const Codec& codec) {
330 return codec.HasFeedbackParam( 330 return codec.HasFeedbackParam(
331 FeedbackParam(kRtcpFbParamNack, kParamValueEmpty)); 331 FeedbackParam(kRtcpFbParamNack, kParamValueEmpty));
332 } 332 }
333 333
334 bool HasRemb(const VideoCodec& codec) { 334 bool HasRemb(const Codec& codec) {
335 return codec.HasFeedbackParam( 335 return codec.HasFeedbackParam(
336 FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty)); 336 FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty));
337 } 337 }
338 338
339 bool HasTransportCc(const VideoCodec& codec) { 339 bool HasTransportCc(const Codec& codec) {
340 return codec.HasFeedbackParam( 340 return codec.HasFeedbackParam(
341 FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty)); 341 FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
342 } 342 }
343 343
344 bool CodecNamesEq(const std::string& name1, const std::string& name2) { 344 bool CodecNamesEq(const std::string& name1, const std::string& name2) {
345 return _stricmp(name1.c_str(), name2.c_str()) == 0; 345 return _stricmp(name1.c_str(), name2.c_str()) == 0;
346 } 346 }
347 347
348 } // namespace cricket 348 } // namespace cricket
OLDNEW
« no previous file with comments | « talk/media/base/codec.h ('k') | talk/media/webrtc/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698