Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 1604403002: Make type and constructors in EglBase14 public. (Closed)

Created:
4 years, 11 months ago by noahric
Modified:
4 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make type and constructors in EglBase14 public. This type is used for GL contexts in android hardware encode/decode, so it seems correct/useful to make it publicly constructable. Committed: https://crrev.com/5082c833203aa6f39a5a97e2d4a1b6f131c54807 Cr-Commit-Position: refs/heads/master@{#11331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/EglBase14.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
noahric
4 years, 11 months ago (2016-01-20 19:01:58 UTC) #2
magjed_webrtc
lgtm
4 years, 11 months ago (2016-01-21 09:05:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604403002/1
4 years, 11 months ago (2016-01-21 09:05:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 10:12:55 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:13:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5082c833203aa6f39a5a97e2d4a1b6f131c54807
Cr-Commit-Position: refs/heads/master@{#11331}

Powered by Google App Engine
This is Rietveld 408576698