Reallocate encoded buffer size if needed. Initially set to the input image size.

Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length > input image size.

BUG=chromium:578193
Committed: https://crrev.com/d9f641e3417d0563626eddf18c38fe6a3532107b
Cr-Commit-Position: refs/heads/master@{#11329}

[åsapersson, 2016-01-19 14:40:33]

Description was changed from

==========
Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length
> input image size.

BUG=chromium:578193
==========

to

==========
Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length
> input image size.

BUG=chromium:578193
==========

[åsapersson, 2016-01-19 14:40:33]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-01-20 12:39:07]

https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:666: encoded_image_._buffer =
new uint8_t[encoded_image_._size];
Don't you have to copy the existing content of the old buffer into the new
buffer? At least that's what line 670 seems to indicate? You should probably
also change 663 to 
if (encoded_image_._length + pkt->data.frame.sz > encoded_iamge_._size) {

Similarly on line 666.

Or is line 670 incorrect?

[åsapersson, 2016-01-20 13:32:00]

https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:666: encoded_image_._buffer =
new uint8_t[encoded_image_._size];
On 2016/01/20 12:39:07, stefan-webrtc (holmer) wrote:
> Don't you have to copy the existing content of the old buffer into the new
> buffer? At least that's what line 670 seems to indicate? You should probably
> also change 663 to 
> if (encoded_image_._length + pkt->data.frame.sz > encoded_iamge_._size) {
> 
> Similarly on line 666.
> 
> Or is line 670 incorrect?

It is only copied once right (line 670).

encoded_image_._length is 0. Change this in another cl?

[stefan-webrtc, 2016-01-20 14:11:02]

lgtm if you decide to change this in a follow-up

https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:666: encoded_image_._buffer =
new uint8_t[encoded_image_._size];
On 2016/01/20 13:32:00, åsapersson wrote:
> On 2016/01/20 12:39:07, stefan-webrtc (holmer) wrote:
> > Don't you have to copy the existing content of the old buffer into the new
> > buffer? At least that's what line 670 seems to indicate? You should probably
> > also change 663 to 
> > if (encoded_image_._length + pkt->data.frame.sz > encoded_iamge_._size) {
> > 
> > Similarly on line 666.
> > 
> > Or is line 670 incorrect?
> 
> It is only copied once right (line 670).
> 
> encoded_image_._length is 0. Change this in another cl?

Sure, if you prefer. Although it should as far as I can tell be enough to just
change &encoded_image_._buffer[encoded_image_._length] to encoded_image_._buffer
below, right?

[åsapersson, 2016-01-21 08:03:10]

On 2016/01/20 14:11:02, stefan-webrtc (holmer) wrote:
> lgtm if you decide to change this in a follow-up
> 
>
https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
> File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):
> 
>
https://codereview.webrtc.org/1603643006/diff/20001/webrtc/modules/video_codi...
> webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:666: encoded_image_._buffer
=
> new uint8_t[encoded_image_._size];
> On 2016/01/20 13:32:00, åsapersson wrote:
> > On 2016/01/20 12:39:07, stefan-webrtc (holmer) wrote:
> > > Don't you have to copy the existing content of the old buffer into the new
> > > buffer? At least that's what line 670 seems to indicate? You should
probably
> > > also change 663 to 
> > > if (encoded_image_._length + pkt->data.frame.sz > encoded_iamge_._size) {
> > > 
> > > Similarly on line 666.
> > > 
> > > Or is line 670 incorrect?
> > 
> > It is only copied once right (line 670).
> > 
> > encoded_image_._length is 0. Change this in another cl?
> 
> Sure, if you prefer. Although it should as far as I can tell be enough to just
> change &encoded_image_._buffer[encoded_image_._length] to
encoded_image_._buffer
> below, right?

Will do a follow-up.

[åsapersson, 2016-01-21 08:11:02]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-01-21 08:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603643006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603643006/20001

[commit-bot: I haz the power, 2016-01-21 09:11:39]

Description was changed from

==========
Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length
> input image size.

BUG=chromium:578193
==========

to

==========
Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length
> input image size.

BUG=chromium:578193
==========

[commit-bot: I haz the power, 2016-01-21 09:11:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 09:11:49]

Description was changed from

==========
Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length
> input image size.

BUG=chromium:578193
==========

to

==========
Reallocate encoded buffer size if needed. Initially set to the input image size.
Issue may occur for very small input images (e.g. 4x4) when encoded image length
> input image size.

BUG=chromium:578193

Committed: https://crrev.com/d9f641e3417d0563626eddf18c38fe6a3532107b
Cr-Commit-Position: refs/heads/master@{#11329}
==========

[commit-bot: I haz the power, 2016-01-21 09:11:50]

Patchset 2 (id:??) landed as
https://crrev.com/d9f641e3417d0563626eddf18c38fe6a3532107b
Cr-Commit-Position: refs/heads/master@{#11329}