Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1602443004: Make it possible to run peerconnection_unittests on Android. (Closed)

Created:
4 years, 11 months ago by perkj_webrtc
Modified:
4 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make it possible to run peerconnection_unittests on Android. - renamed libjingle_peerconnection_unittest to peerconnection_unittest to circumvent cr issue http://crbug.com/543820 TEST=On an android build webrtc/build/android/test_runner.py gtest -s peerconnection_unittests --verbose -t 900 BUG=webrtc:2365, 543820 NOTRY=True Committed: https://crrev.com/8a2c31d2085df0365f7dad8fc6cd28dc24ffae59 Cr-Commit-Position: refs/heads/master@{#11304}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Added missing peerconnection_unittests.isolate #

Total comments: 1

Patch Set 4 : fix isolate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -100 lines) Patch
D talk/libjingle_peerconnection_unittest.isolate View 1 chunk +0 lines, -40 lines 0 comments Download
M talk/libjingle_tests.gyp View 4 chunks +7 lines, -7 lines 0 comments Download
A + talk/peerconnection_unittests.isolate View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/build/android/test_runner.py View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/build/apk_test.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/build/apk_tests.gyp View 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/build/apk_tests_noop.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/sanitizers/lsan_suppressions_webrtc.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
perkj_webrtc
Please?
4 years, 11 months ago (2016-01-18 13:17:02 UTC) #3
kjellander_webrtc
add 543820 to the BUG= list as well. lgtm
4 years, 11 months ago (2016-01-18 13:20:40 UTC) #4
kjellander_webrtc
On 2016/01/18 13:20:40, kjellander (webrtc) wrote: > add 543820 to the BUG= list as well. ...
4 years, 11 months ago (2016-01-18 13:23:17 UTC) #5
kjellander_webrtc
https://codereview.webrtc.org/1602443004/diff/40001/talk/peerconnection_unittests.isolate File talk/peerconnection_unittests.isolate (right): https://codereview.webrtc.org/1602443004/diff/40001/talk/peerconnection_unittests.isolate#newcode32 talk/peerconnection_unittests.isolate:32: '<(PRODUCT_DIR)/libjingle_peerconnection_unittest<(EXECUTABLE_SUFFIX)', Update the executable name to peerconnection_unittests
4 years, 11 months ago (2016-01-19 13:58:12 UTC) #8
perkj_webrtc
Nu då!
4 years, 11 months ago (2016-01-19 14:10:11 UTC) #9
kjellander_webrtc
On 2016/01/19 14:10:11, perkj_webrtc wrote: > Nu då! lgtm, I aborted some of the bots ...
4 years, 11 months ago (2016-01-19 14:14:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602443004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602443004/60001
4 years, 11 months ago (2016-01-19 14:15:47 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-19 14:20:05 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 14:20:15 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8a2c31d2085df0365f7dad8fc6cd28dc24ffae59
Cr-Commit-Position: refs/heads/master@{#11304}

Powered by Google App Engine
This is Rietveld 408576698