Delete GetRenderer method, used only by the tests.

Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426
Committed: https://crrev.com/d26fadb4545027ba2d548c01441bc7434992b470
Cr-Commit-Position: refs/heads/master@{#11328}

[nisse-webrtc, 2016-01-20 12:25:04]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org

[nisse-webrtc, 2016-01-20 12:25:04]

There's a TODO saying that the method ought to be deleted, and I'm trying to
reduce the number of places exposing the cricket::VideoRenderer interface.

It was used in the tests, and those testcases now get less interesting. Not sure
if we can add some other way of testing that the right renderer is attached,
e.g,, by inserting a frame and check where it turns up.

[nisse-webrtc, 2016-01-20 12:46:06]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 12:46:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602283003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602283003/20001

[nisse-webrtc, 2016-01-20 12:46:39]

Description was changed from

==========
Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426
==========

to

==========
Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426
==========

[nisse-webrtc, 2016-01-20 12:46:39]

nisse@webrtc.org changed reviewers:
+ tommi@webrtc.org

[pbos-webrtc, 2016-01-20 13:28:16]

https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
File talk/media/base/videoengine_unittest.h (right):

https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
talk/media/base/videoengine_unittest.h:794: void
AddRemoveRecvStreamsNoConference() {
Do these tests now check anything useful?

[nisse-webrtc, 2016-01-20 13:49:28]

https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
File talk/media/base/videoengine_unittest.h (right):

https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
talk/media/base/videoengine_unittest.h:794: void
AddRemoveRecvStreamsNoConference() {
On 2016/01/20 13:28:16, pbos-webrtc wrote:
> Do these tests now check anything useful?

They check return values. Not sure if that's useful or not.

[pbos-webrtc, 2016-01-20 13:57:17]

On 2016/01/20 13:49:28, nisse-webrtc wrote:
>
https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
> File talk/media/base/videoengine_unittest.h (right):
> 
>
https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
> talk/media/base/videoengine_unittest.h:794: void
> AddRemoveRecvStreamsNoConference() {
> On 2016/01/20 13:28:16, pbos-webrtc wrote:
> > Do these tests now check anything useful?
> 
> They check return values. Not sure if that's useful or not.

Nah, please remove them. Also I think VideoRenderers (or sinks) should be set on
::AddRecvStream here. If you don't mind putting that on your TODO, that's a
potential thing you could also do.

[nisse-webrtc, 2016-01-20 14:11:55]

On 2016/01/20 13:57:17, pbos-webrtc wrote:
> On 2016/01/20 13:49:28, nisse-webrtc wrote:
> >
>
https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
> > File talk/media/base/videoengine_unittest.h (right):
> > 
> >
>
https://codereview.webrtc.org/1602283003/diff/20001/talk/media/base/videoengi...
> > talk/media/base/videoengine_unittest.h:794: void
> > AddRemoveRecvStreamsNoConference() {
> > On 2016/01/20 13:28:16, pbos-webrtc wrote:
> > > Do these tests now check anything useful?
> > 
> > They check return values. Not sure if that's useful or not.
> 
> Nah, please remove them. Also I think VideoRenderers (or sinks) should be set
on
> ::AddRecvStream here. If you don't mind putting that on your TODO, that's a
> potential thing you could also do.

Ok, those tests now deleted.

[pbos-webrtc, 2016-01-20 14:12:39]

lgtm

[nisse-webrtc, 2016-01-20 14:23:54]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 14:23:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602283003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602283003/40001

[tommi, 2016-01-20 15:14:23]

lgtm

[commit-bot: I haz the power, 2016-01-20 16:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 16:51:44]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2016-01-21 07:23:07]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-01-21 07:23:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602283003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602283003/40001

[commit-bot: I haz the power, 2016-01-21 07:26:41]

Description was changed from

==========
Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426
==========

to

==========
Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-01-21 07:26:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 07:26:48]

Description was changed from

==========
Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426
==========

to

==========
Delete GetRenderer method, used only by the tests.

BUG=webrtc:5426

Committed: https://crrev.com/d26fadb4545027ba2d548c01441bc7434992b470
Cr-Commit-Position: refs/heads/master@{#11328}
==========

[commit-bot: I haz the power, 2016-01-21 07:26:49]

Patchset 3 (id:??) landed as
https://crrev.com/d26fadb4545027ba2d548c01441bc7434992b470
Cr-Commit-Position: refs/heads/master@{#11328}