Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1602203003: Remove unused ConditionVariableWrapper on POSIX platforms (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused ConditionVariableWrapper on POSIX platforms BUG= Committed: https://crrev.com/cd255cc07b04143829bbffebd5c234c76eccb39a Cr-Commit-Position: refs/heads/master@{#11308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -188 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/include/condition_variable_wrapper.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/include/critical_section_wrapper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable.cc View 2 chunks +7 lines, -13 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_posix.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_posix.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tommi
4 years, 11 months ago (2016-01-19 17:40:02 UTC) #2
pbos-webrtc
lgtm, high-five, A++/10 would buy again.
4 years, 11 months ago (2016-01-19 20:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602203003/1
4 years, 11 months ago (2016-01-19 21:07:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 21:13:18 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 21:13:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cd255cc07b04143829bbffebd5c234c76eccb39a
Cr-Commit-Position: refs/heads/master@{#11308}

Powered by Google App Engine
This is Rietveld 408576698