Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: webrtc/modules/video_coding/BUILD.gn

Issue 1601813005: rtc_use_h264 flag for building OpenH264/FFmpeg (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: use_h264=true on all supported platforms (!ios), will default to false before landing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/BUILD.gn
diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn
index 32ac627ed244239ff8221028e0afca736261e5c4..9f70dfdeb5939f5a55c676ae664f5dd70f93c47e 100644
--- a/webrtc/modules/video_coding/BUILD.gn
+++ b/webrtc/modules/video_coding/BUILD.gn
@@ -137,12 +137,11 @@ source_set("webrtc_h264") {
"../../system_wrappers",
]
- if (use_third_party_h264) {
- # Dependency added so that variables use_openh264 and ffmpeg_branding are
- # recognized build arguments (avoid "Build argument has no effect" error).
- # The variables and dependencies will be used for real as soon as
- # https://codereview.webrtc.org/1306813009/ lands. In the meantime, the
- # build arguments are to be used by waterfall/trybots.
+ if (use_h264) {
+ # Dependency for sake of compiling and so that variables use_openh264 and
+ # ffmpeg_branding are recognized build arguments (avoid "Build argument has
+ # no effect" error). The variables and dependencies will be used for real as
+ # soon as https://codereview.webrtc.org/1306813009/ lands.
deps += [
"//third_party/ffmpeg:ffmpeg",
"//third_party/openh264:encoder",

Powered by Google App Engine
This is Rietveld 408576698