Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1601033004: Remove use-after-free when quality tests stall. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove use-after-free when quality tests stall. Reduces TSan warnings when running screenshare FullStack tests. BUG= R=sprang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/dd45eb68018a621a81ffa6983519573496efe185

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M webrtc/video/video_quality_test.cc View 3 chunks +8 lines, -12 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
PTAL
4 years, 11 months ago (2016-01-19 13:36:50 UTC) #1
pbos-webrtc
PTAL https://codereview.webrtc.org/1601033004/diff/1/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (left): https://codereview.webrtc.org/1601033004/diff/1/webrtc/video/video_quality_test.cc#oldcode246 webrtc/video/video_quality_test.cc:246: ASSERT_GT(frames_processed, last_frames_processed) This ASSERT caused the function to ...
4 years, 11 months ago (2016-01-19 13:37:28 UTC) #2
sprang_webrtc
lgtm
4 years, 11 months ago (2016-01-19 14:12:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd45eb68018a621a81ffa6983519573496efe185 Cr-Commit-Position: refs/heads/master@{#11305}
4 years, 11 months ago (2016-01-19 14:22:47 UTC) #5
pbos-webrtc
4 years, 11 months ago (2016-01-19 14:22:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd45eb68018a621a81ffa6983519573496efe185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698