Name SimulcastEncoderApdater on InitEncode.

Name SimulcastEncoderApdater on InitEncode.

Provides a better string (provides names of all implementations), but
also fixes a crash when accessing the ImplementationName() of
SimulcastEncoderAdapter where InitEncode has failed.

BUG=chromium:577932, webrtc:4897
R=stefan@webrtc.org

Committed: https://crrev.com/a5dec16b42b1f9c36c10ebd10e5609e6752c67a0
Cr-Commit-Position: refs/heads/master@{#11321}

[pbos-webrtc, 2016-01-18 22:37:38]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[pbos-webrtc, 2016-01-18 22:37:46]

PTAL

[commit-bot: I haz the power, 2016-01-18 22:37:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1599353003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1599353003/1

[commit-bot: I haz the power, 2016-01-19 00:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 00:38:05]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2016-01-20 14:18:12]

maybe a test to verify different names here?

https://codereview.webrtc.org/1599353003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
(right):

https://codereview.webrtc.org/1599353003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc:232:
implementation_name += streaminfos_[0].encoder->ImplementationName();
i?

[pbos-webrtc, 2016-01-20 14:43:58]

unittest + implementation fix

[pbos-webrtc, 2016-01-20 14:44:38]

Good idea, caught 2 bugs. :\

https://codereview.webrtc.org/1599353003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
(right):

https://codereview.webrtc.org/1599353003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc:232:
implementation_name += streaminfos_[0].encoder->ImplementationName();
On 2016/01/20 14:18:12, stefan-webrtc (holmer) wrote:
> i?

Done.

[stefan-webrtc, 2016-01-20 14:50:56]

lgtm

[pbos-webrtc, 2016-01-20 14:54:07]

Description was changed from

==========
Name SimulcastEncoderApdater on InitEncode.

Provides a better string (provides names of all implementations), but
also fixes a crash when accessing the ImplementationName() of
SimulcastEncoderAdapter where InitEncode has failed.

BUG=chromium:577932, webrtc:4897
R=stefan@webrtc.org
==========

to

==========
Name SimulcastEncoderApdater on InitEncode.

Provides a better string (provides names of all implementations), but
also fixes a crash when accessing the ImplementationName() of
SimulcastEncoderAdapter where InitEncode has failed.

BUG=chromium:577932, webrtc:4897
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a5dec16b42b1f9c36c10ebd10...
==========

[commit-bot: I haz the power, 2016-01-20 14:54:07]

Description was changed from

==========
Name SimulcastEncoderApdater on InitEncode.

Provides a better string (provides names of all implementations), but
also fixes a crash when accessing the ImplementationName() of
SimulcastEncoderAdapter where InitEncode has failed.

BUG=chromium:577932, webrtc:4897
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a5dec16b42b1f9c36c10ebd10...
==========

to

==========
Name SimulcastEncoderApdater on InitEncode.

Provides a better string (provides names of all implementations), but
also fixes a crash when accessing the ImplementationName() of
SimulcastEncoderAdapter where InitEncode has failed.

BUG=chromium:577932, webrtc:4897
R=stefan@webrtc.org

Committed: https://crrev.com/a5dec16b42b1f9c36c10ebd10e5609e6752c67a0
Cr-Commit-Position: refs/heads/master@{#11321}
==========

[pbos-webrtc, 2016-01-20 14:54:08]

Committed patchset #2 (id:20001) manually as
a5dec16b42b1f9c36c10ebd10e5609e6752c67a0 (presubmit successful).

[commit-bot: I haz the power, 2016-01-20 14:54:08]

Patchset 2 (id:??) landed as
https://crrev.com/a5dec16b42b1f9c36c10ebd10e5609e6752c67a0
Cr-Commit-Position: refs/heads/master@{#11321}