Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 1598803005: Remove vp8_factory.{cc,h}. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove vp8_factory.{cc,h}. Removes use of global VP8EncoderFactory::use_simulcast_adapter which is thread-unsafe. Also the code wasn't in use. BUG= R=stefan@webrtc.org Committed: https://crrev.com/85b22e2306bd05bea2a4c7f25489c4fca5c7b8b7 Cr-Commit-Position: refs/heads/master@{#11370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -90 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 chunk +12 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/vp8_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/vp8_factory.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pbos-webrtc
PTAL
4 years, 11 months ago (2016-01-18 22:59:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598803005/1
4 years, 11 months ago (2016-01-18 22:59:35 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
4 years, 11 months ago (2016-01-19 00:59:50 UTC) #5
stefan-webrtc
lgtm
4 years, 11 months ago (2016-01-25 14:35:31 UTC) #6
pbos-webrtc
Committed patchset #1 (id:1) manually as 85b22e2306bd05bea2a4c7f25489c4fca5c7b8b7 (presubmit successful).
4 years, 11 months ago (2016-01-25 16:58:12 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 16:58:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85b22e2306bd05bea2a4c7f25489c4fca5c7b8b7
Cr-Commit-Position: refs/heads/master@{#11370}

Powered by Google App Engine
This is Rietveld 408576698