Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Since this is on Windows only, I'm also using the CriticalSectionWrapper and ConditionVariableWrapper Windows types directly which allows us to skip 3 extra heap allocations. It also helps with the removal of the 'friend' relationship between ConditionVariableWrapper and CriticalSectionWrapper, which is causing headaches on Mac.

BUG=

Committed: https://crrev.com/61046eb38d188c759478c84fb536ec8dd941e146
Cr-Commit-Position: refs/heads/master@{#11300}

[tommi, 2016-01-16 17:21:43]

Fix missing include

[tommi, 2016-01-16 17:23:52]

tommi@webrtc.org changed reviewers:
+ magjed@webrtc.org

[tommi, 2016-01-18 09:13:32]

tommi@webrtc.org changed reviewers:
+ mflodman@webrtc.org
- magjed@webrtc.org

[tommi, 2016-01-18 09:13:32]

hej magnus - ptal

[tommi, 2016-01-18 09:21:55]

Description was changed from

==========
Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

BUG=
==========

to

==========
Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Since this is on Windows only, I'm also using the CriticalSectionWrapper and
ConditionVariableWrapper Windows types directly which allows us to skip 3 extra
heap allocations. It also helps with the removal of the 'friend' relationship
between ConditionVariableWrapper and CriticalSectionWrapper, which is causing
headaches on Mac.

BUG=
==========

[tommi, 2016-01-19 08:44:38]

ping

[mflodman, 2016-01-19 09:55:32]

One comment, then LGTM.

https://codereview.webrtc.org/1595983002/diff/20001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/rw_lock_winxp_win.h (right):

https://codereview.webrtc.org/1595983002/diff/20001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/rw_lock_winxp_win.h:14: #include <windows.h>
We shouldn't need this include here.

[tommi, 2016-01-19 10:02:51]

Remove include

[tommi, 2016-01-19 10:03:07]

https://codereview.webrtc.org/1595983002/diff/20001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/rw_lock_winxp_win.h (right):

https://codereview.webrtc.org/1595983002/diff/20001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/rw_lock_winxp_win.h:14: #include <windows.h>
On 2016/01/19 09:55:32, mflodman wrote:
> We shouldn't need this include here.

Done.

[tommi, 2016-01-19 10:03:17]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-01-19 10:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1595983002/#ps40001 (title:
"Remove include")

[commit-bot: I haz the power, 2016-01-19 10:03:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1595983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1595983002/40001

[commit-bot: I haz the power, 2016-01-19 11:00:00]

Description was changed from

==========
Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Since this is on Windows only, I'm also using the CriticalSectionWrapper and
ConditionVariableWrapper Windows types directly which allows us to skip 3 extra
heap allocations. It also helps with the removal of the 'friend' relationship
between ConditionVariableWrapper and CriticalSectionWrapper, which is causing
headaches on Mac.

BUG=
==========

to

==========
Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Since this is on Windows only, I'm also using the CriticalSectionWrapper and
ConditionVariableWrapper Windows types directly which allows us to skip 3 extra
heap allocations. It also helps with the removal of the 'friend' relationship
between ConditionVariableWrapper and CriticalSectionWrapper, which is causing
headaches on Mac.

BUG=
==========

[commit-bot: I haz the power, 2016-01-19 11:00:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-19 11:00:05]

Description was changed from

==========
Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Since this is on Windows only, I'm also using the CriticalSectionWrapper and
ConditionVariableWrapper Windows types directly which allows us to skip 3 extra
heap allocations. It also helps with the removal of the 'friend' relationship
between ConditionVariableWrapper and CriticalSectionWrapper, which is causing
headaches on Mac.

BUG=
==========

to

==========
Rename RWLockGeneric to RWLockWinXP to more accurately reflect when it's used.

Since this is on Windows only, I'm also using the CriticalSectionWrapper and
ConditionVariableWrapper Windows types directly which allows us to skip 3 extra
heap allocations. It also helps with the removal of the 'friend' relationship
between ConditionVariableWrapper and CriticalSectionWrapper, which is causing
headaches on Mac.

BUG=

Committed: https://crrev.com/61046eb38d188c759478c84fb536ec8dd941e146
Cr-Commit-Position: refs/heads/master@{#11300}
==========

[commit-bot: I haz the power, 2016-01-19 11:00:06]

Patchset 3 (id:??) landed as
https://crrev.com/61046eb38d188c759478c84fb536ec8dd941e146
Cr-Commit-Position: refs/heads/master@{#11300}