talk/session/media/channelmanager.h - Issue 1594973006: New rtc::VideoSinkInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/session/media/channelmanager.h

Issue 1594973006: New rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Use rtc::VideoSinkInterface on the call chain VideoSource --> CaptureRenderAdapter Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/session/media/channelmanager.h

diff --git a/talk/session/media/channelmanager.h b/talk/session/media/channelmanager.h

index f69bf9a2935c2a25bca79a555e2e3e49a4118031..bbe517dc8625d9ecb40e1ce54ebbe62ad5d6142a 100644

--- a/talk/session/media/channelmanager.h

+++ b/talk/session/media/channelmanager.h

@@ -156,8 +156,12 @@ class ChannelManager : public rtc::MessageHandler,

const VideoFormat& desired_format,

CaptureManager::RestartOptions options);

- bool AddVideoRenderer(VideoCapturer* capturer, VideoRenderer* renderer);

- bool RemoveVideoRenderer(VideoCapturer* capturer, VideoRenderer* renderer);

+ // TODO(nisse): Return values are mostly useless. Currently, these

+ // methods tolerate nullptr inputs, probably not needed.

+ virtual bool AddVideoSink(VideoCapturer* video_capturer,

+ rtc::VideoSinkInterface<VideoFrame>* sink);

+ virtual bool RemoveVideoSink(VideoCapturer* video_capturer,

+ rtc::VideoSinkInterface<VideoFrame>* sink);

bool IsScreencastRunning() const;

// The operations below occur on the main thread.