Chromium Code Reviews| Index: talk/media/base/capturemanager.h |
| diff --git a/talk/media/base/capturemanager.h b/talk/media/base/capturemanager.h |
| index 8cbbf5258c4dbe57744c1d1a4450dcf48197dabe..586a6cd4c15ddcda27da4fe0c28f900b3657b1d3 100644 |
| --- a/talk/media/base/capturemanager.h |
| +++ b/talk/media/base/capturemanager.h |
| @@ -79,10 +79,12 @@ class CaptureManager : public sigslot::has_slots<> { |
| const VideoFormat& desired_format, |
| RestartOptions options); |
| - virtual bool AddVideoRenderer(VideoCapturer* video_capturer, |
| - VideoRenderer* video_renderer); |
| - virtual bool RemoveVideoRenderer(VideoCapturer* video_capturer, |
| - VideoRenderer* video_renderer); |
| + // TODO(nisse): Return values are mostly useless. Currently, these |
| + // methods tolerate nullptr inputs, probably not needed. |
| + virtual bool AddVideoSink(VideoCapturer* video_capturer, |
| + rtc::VideoSinkInterface<VideoFrame>* sink); |
|
pthatcher1
2016/01/27 01:11:03
Can you just make these void? You can either retu
nisse-webrtc
2016/01/27 09:08:51
Done, deleting return values also for the ChannelM
|
| + virtual bool RemoveVideoSink(VideoCapturer* video_capturer, |
| + rtc::VideoSinkInterface<VideoFrame>* sink); |
| sigslot::repeater2<VideoCapturer*, CaptureState> SignalCapturerStateChange; |