Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1592763003: fix bug 5430 (Closed)

Created:
4 years, 11 months ago by guoweis_webrtc
Modified:
4 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

fix bug 5430 Fixed misusage of Connection function and also fixed the test case. BUG=webrtc:5430 Committed: https://crrev.com/56271ed8894fb2e985c9b366e4e38313a4652d63 Cr-Commit-Position: refs/heads/master@{#11278}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add check against empty networks. #

Patch Set 3 : Fix ipv6 test failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M webrtc/base/network.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/base/network_unittest.cc View 1 2 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
guoweis_webrtc
PTAL.
4 years, 11 months ago (2016-01-15 18:11:08 UTC) #2
pthatcher1
lgtm https://codereview.webrtc.org/1592763003/diff/1/webrtc/base/network_unittest.cc File webrtc/base/network_unittest.cc (right): https://codereview.webrtc.org/1592763003/diff/1/webrtc/base/network_unittest.cc#newcode954 webrtc/base/network_unittest.cc:954: std::vector<Network*> networks; Should we EXPECT_TRUE(!networks.empty()) ?
4 years, 11 months ago (2016-01-15 19:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1592763003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1592763003/60001
4 years, 11 months ago (2016-01-15 21:57:05 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 11 months ago (2016-01-15 22:45:09 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 22:45:18 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56271ed8894fb2e985c9b366e4e38313a4652d63
Cr-Commit-Position: refs/heads/master@{#11278}

Powered by Google App Engine
This is Rietveld 408576698