Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1592763002: [rtp_rtcp] rtcp::Sdes moved into own file (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -201 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 2 chunks +0 lines, -57 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 3 chunks +0 lines, -86 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danilchap
4 years, 11 months ago (2016-01-15 14:35:49 UTC) #1
åsapersson
lgtm
4 years, 11 months ago (2016-01-15 16:22:52 UTC) #2
danilchap
Committed patchset #2 (id:20001) manually as 1567d0bd98f22b8da5ba9e6b1c3106988a479284 (presubmit successful).
4 years, 11 months ago (2016-01-15 16:34:37 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 16:34:38 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1567d0bd98f22b8da5ba9e6b1c3106988a479284
Cr-Commit-Position: refs/heads/master@{#11274}

Powered by Google App Engine
This is Rietveld 408576698