Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in UdpSocketPosix.

Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in UdpSocketPosix.
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's implementation where it accesses private variables of CriticalSectionWrapper, which is not good since it makes assumptions about the implementation on all posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we have, and fits the requirements of UdpSocketPosix.

BUG=
R=pbos@webrtc.org

Committed: https://crrev.com/2067826a5e2c433121dd5c3b846a71ba3e1987cf
Cr-Commit-Position: refs/heads/master@{#11295}

[tommi, 2016-01-16 18:02:49]

tommi@webrtc.org changed reviewers:
+ pbos@webrtc.org

[tommi, 2016-01-18 09:12:01]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-18 09:12:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1591333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1591333002/1

[commit-bot: I haz the power, 2016-01-18 10:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-18 10:19:34]

Dry run: Try jobs failed on following builders:
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/11895)
  linux_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/12121)

[tommi, 2016-01-18 14:10:31]

Fix hang

[pbos-webrtc, 2016-01-18 14:54:42]

lgtm

[pbos-webrtc, 2016-01-18 14:55:29]

Feel free to remove:

webrtc/test/channel_transport/udp_socket_manager_posix.h:27:class
ConditionVariableWrapper;

If possible with this.

[tommi, 2016-01-18 15:21:33]

Remove unnecessary fwd decl

[tommi, 2016-01-18 15:22:28]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-01-18 15:22:29]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1591333002/#ps40001 (title:
"Remove unnecessary fwd decl")

[commit-bot: I haz the power, 2016-01-18 15:22:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1591333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1591333002/40001

[commit-bot: I haz the power, 2016-01-18 16:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-18 16:33:57]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/10386)

[tommi, 2016-01-18 17:43:51]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2016-01-18 17:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1591333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1591333002/40001

[tommi, 2016-01-18 19:35:53]

Description was changed from

==========
Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in
UdpSocketPosix.
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's
implementation where it accesses private variables of CriticalSectionWrapper,
which is not good since it makes assumptions about the implementation on all
posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we
have, and fits the requirements of UdpSocketPosix.

BUG=
==========

to

==========
Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in
UdpSocketPosix.
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's
implementation where it accesses private variables of CriticalSectionWrapper,
which is not good since it makes assumptions about the implementation on all
posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we
have, and fits the requirements of UdpSocketPosix.

BUG=
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/2067826a5e2c433121dd5c3b8...
==========

[tommi, 2016-01-18 19:35:54]

Committed patchset #3 (id:40001) manually as
2067826a5e2c433121dd5c3b846a71ba3e1987cf (presubmit successful).

[commit-bot: I haz the power, 2016-01-18 19:35:56]

Description was changed from

==========
Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in
UdpSocketPosix.
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's
implementation where it accesses private variables of CriticalSectionWrapper,
which is not good since it makes assumptions about the implementation on all
posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we
have, and fits the requirements of UdpSocketPosix.

BUG=
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/2067826a5e2c433121dd5c3b8...
==========

to

==========
Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in
UdpSocketPosix.
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's
implementation where it accesses private variables of CriticalSectionWrapper,
which is not good since it makes assumptions about the implementation on all
posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we
have, and fits the requirements of UdpSocketPosix.

BUG=
R=pbos@webrtc.org

Committed: https://crrev.com/2067826a5e2c433121dd5c3b846a71ba3e1987cf
Cr-Commit-Position: refs/heads/master@{#11295}
==========

[commit-bot: I haz the power, 2016-01-18 19:35:56]

Patchset 3 (id:??) landed as
https://crrev.com/2067826a5e2c433121dd5c3b846a71ba3e1987cf
Cr-Commit-Position: refs/heads/master@{#11295}