Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1590983005: Simplify the implementation of LoggingTest. (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simplify the implementation of LoggingTest. This removes dependency on ConditionVariableWrapper and CriticalSectionWrapper which currently have a 'friend' relationship that I'd like to get rid of. BUG= Committed: https://crrev.com/aff4b70db0bf8e6507d29f9316512ef8106704bf Cr-Commit-Position: refs/heads/master@{#11292}

Patch Set 1 #

Patch Set 2 : Remove unnecessary expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -47 lines) Patch
M webrtc/system_wrappers/source/logging_unittest.cc View 1 1 chunk +29 lines, -47 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tommi
Remove unnecessary expectation
4 years, 11 months ago (2016-01-16 15:20:18 UTC) #1
tommi
4 years, 11 months ago (2016-01-16 15:22:58 UTC) #3
tommi
Hej pbos - ptal
4 years, 11 months ago (2016-01-18 09:10:23 UTC) #5
pbos-webrtc
lgtm
4 years, 11 months ago (2016-01-18 14:23:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590983005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590983005/20001
4 years, 11 months ago (2016-01-18 14:30:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-18 16:31:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590983005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590983005/20001
4 years, 11 months ago (2016-01-18 18:16:41 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-18 18:20:21 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 18:20:28 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aff4b70db0bf8e6507d29f9316512ef8106704bf
Cr-Commit-Position: refs/heads/master@{#11292}

Powered by Google App Engine
This is Rietveld 408576698