Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1589573004: Re-land: "Use an explicit identifier in Config" (Closed)

Created:
4 years, 11 months ago by aluebs-webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi, aluebs-google
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, video-team_agora.io, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, zhengzhonghou_agora.io, hlundin-webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-land: "Use an explicit identifier in Config" This let's us use them to configure them when using WebRTC as an external library. One use case where this is necessary is in the Android OS. Original CL: https://codereview.webrtc.org/1538643004/ TBR=tommi@webrtc.org Committed: https://crrev.com/688e308a353c27803a66803230235638f4dd1f2b Cr-Commit-Position: refs/heads/master@{#11248}

Patch Set 1 #

Patch Set 2 : Fix error in Chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M talk/libjingle.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/common.h View 4 chunks +20 lines, -7 lines 0 comments Download
M webrtc/config.h View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 6 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/temporal_layers.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/test/common_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
aluebs-webrtc
Fixed error in Chrome and re-landing this.
4 years, 11 months ago (2016-01-13 23:49:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589573004/20001
4 years, 11 months ago (2016-01-13 23:49:33 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/324)
4 years, 11 months ago (2016-01-14 01:35:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589573004/20001
4 years, 11 months ago (2016-01-14 01:37:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 11 months ago (2016-01-14 01:49:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589573004/20001
4 years, 11 months ago (2016-01-14 01:52:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/328)
4 years, 11 months ago (2016-01-14 02:57:35 UTC) #13
tommi
lgtm
4 years, 11 months ago (2016-01-14 12:31:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589573004/20001
4 years, 11 months ago (2016-01-14 12:31:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 12:32:49 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 12:32:56 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/688e308a353c27803a66803230235638f4dd1f2b
Cr-Commit-Position: refs/heads/master@{#11248}

Powered by Google App Engine
This is Rietveld 408576698