Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1589563003: Reland Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. Chromium reported errors when building libjingle_nacl due to some methods used virtual instead of override when they were overriding the base class. My guess is that when one method starts using override, all other in the same class must too. R=tommi@webrtc.org TBR=pthatcher@webtrc.org BUG=4173 Committed: https://crrev.com/55674ffb32307c6f3efaab442340d3c5c075073b Cr-Commit-Position: refs/heads/master@{#11251}

Patch Set 1 #

Patch Set 2 : Fix build issues when building with Chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -43 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/relayport.h View 1 5 chunks +19 lines, -13 lines 0 comments Download
M webrtc/p2p/base/relayport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/stunport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/tcpport.h View 1 5 chunks +24 lines, -19 lines 0 comments Download
M webrtc/p2p/base/tcpport.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/p2p/base/turnport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
stefan-webrtc
Fix build issues when building with Chromium.
4 years, 11 months ago (2016-01-14 14:33:36 UTC) #1
stefan-webrtc
4 years, 11 months ago (2016-01-14 14:35:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589563003/20001
4 years, 11 months ago (2016-01-14 14:38:49 UTC) #7
tommi
lgtm
4 years, 11 months ago (2016-01-14 14:41:48 UTC) #8
stefan-webrtc
Committed patchset #2 (id:20001) manually as 55674ffb32307c6f3efaab442340d3c5c075073b (presubmit successful).
4 years, 11 months ago (2016-01-14 14:49:30 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 14:49:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55674ffb32307c6f3efaab442340d3c5c075073b
Cr-Commit-Position: refs/heads/master@{#11251}

Powered by Google App Engine
This is Rietveld 408576698