Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1589523002:
Add tests for verifying transport feedback for audio and video. (Closed)
|
Created:
4 years, 11 months ago by stefan-webrtc Modified:
4 years, 11 months ago Reviewers:
mflodman CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd tests for verifying transport feedback for audio and video.
BUG=webrtc:5263
R=mflodman@webrtc.org
Committed: https://crrev.com/04cb763955aadf29324ec124b55aa399a7645d51
Cr-Commit-Position: refs/heads/master@{#11255}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix failing tests by defaulting to 1 video stream. #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Added tests for verifying transport feedback for audio and video. BUG=webrtc:5263 ========== to ========== Add tests for verifying transport feedback for audio and video. BUG=webrtc:5263 ==========
stefan@webrtc.org changed reviewers: + mflodman@webrtc.org
The CQ bit was checked by stefan@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589523002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/11816)
One Q, then LGTM. https://codereview.webrtc.org/1589523002/diff/1/webrtc/test/call_test.cc File webrtc/test/call_test.cc (right): https://codereview.webrtc.org/1589523002/diff/1/webrtc/test/call_test.cc#newc... webrtc/test/call_test.cc:63: test->OnCallsCreated(sender_call_.get(), receiver_call_.get()); Any particular reason for moving this?
https://codereview.webrtc.org/1589523002/diff/1/webrtc/test/call_test.cc File webrtc/test/call_test.cc (right): https://codereview.webrtc.org/1589523002/diff/1/webrtc/test/call_test.cc#newc... webrtc/test/call_test.cc:63: test->OnCallsCreated(sender_call_.get(), receiver_call_.get()); On 2016/01/14 08:53:16, mflodman wrote: > Any particular reason for moving this? There was a reason. The previous version of the test had a separate transport class which monitored packets, and it needed access to the receiver call to create its DirectTransport. Now I have refactored even more, and this is no longer needed, but I think it makes sense to call OnCallsCreated as early as possible anyway to give the tests more freedom.
Fix failing tests by defaulting to 1 video stream.
The CQ bit was checked by stefan@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org Link to the patchset: https://codereview.webrtc.org/1589523002/#ps20001 (title: "Fix failing tests by defaulting to 1 video stream.")
The CQ bit was unchecked by stefan@webrtc.org
The CQ bit was checked by stefan@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589523002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Add tests for verifying transport feedback for audio and video. BUG=webrtc:5263 ========== to ========== Add tests for verifying transport feedback for audio and video. BUG=webrtc:5263 R=mflodman@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/04cb763955aadf29324ec124b... ==========
Message was sent while issue was closed.
Description was changed from ========== Add tests for verifying transport feedback for audio and video. BUG=webrtc:5263 R=mflodman@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/04cb763955aadf29324ec124b... ========== to ========== Add tests for verifying transport feedback for audio and video. BUG=webrtc:5263 R=mflodman@webrtc.org Committed: https://crrev.com/04cb763955aadf29324ec124b55aa399a7645d51 Cr-Commit-Position: refs/heads/master@{#11255} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 04cb763955aadf29324ec124b55aa399a7645d51 (presubmit successful).
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/04cb763955aadf29324ec124b55aa399a7645d51 Cr-Commit-Position: refs/heads/master@{#11255} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
