Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1589493004: Update with new default boringssl no-aes cipher suites and re-enable many tests. (Closed)

Created:
4 years, 11 months ago by torbjorng (webrtc)
Modified:
4 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adapt to boringssl's new defaults. This is now a merge with patchset #2 of https://codereview.webrtc.org/1550773002 after that CL was reverted. BUG=webrtc:5381 Committed: https://crrev.com/79a5a83e10ec737be0a372e32420e844c4cef30a Cr-Commit-Position: refs/heads/master@{#11273}

Patch Set 1 #

Patch Set 2 : Merge https://codereview.webrtc.org/1550773002#2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -144 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 2 chunks +20 lines, -3 lines 1 comment Download
M webrtc/base/sslstreamadapter_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 12 chunks +15 lines, -128 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589493004/1
4 years, 11 months ago (2016-01-14 15:03:11 UTC) #3
torbjorng (webrtc)
4 years, 11 months ago (2016-01-14 16:11:28 UTC) #6
tommi
lgtm
4 years, 11 months ago (2016-01-14 16:13:32 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-14 17:03:22 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589493004/20001
4 years, 11 months ago (2016-01-15 13:57:44 UTC) #11
torbjorng (webrtc)
PTAL, tommi.
4 years, 11 months ago (2016-01-15 14:36:51 UTC) #14
tommi
lgtm https://codereview.webrtc.org/1589493004/diff/20001/webrtc/base/opensslstreamadapter.cc File webrtc/base/opensslstreamadapter.cc (right): https://codereview.webrtc.org/1589493004/diff/20001/webrtc/base/opensslstreamadapter.cc#newcode167 webrtc/base/opensslstreamadapter.cc:167: // boringssl versions. TODO(torbjorng): Remove this. nit: Move ...
4 years, 11 months ago (2016-01-15 14:39:19 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 14:54:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589493004/20001
4 years, 11 months ago (2016-01-15 15:15:54 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 15:16:54 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 15:17:02 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79a5a83e10ec737be0a372e32420e844c4cef30a
Cr-Commit-Position: refs/heads/master@{#11273}

Powered by Google App Engine
This is Rietveld 408576698