Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1589433002: Add build_protobuf variable. (Closed)

Created:
4 years, 11 months ago by kjellander_webrtc
Modified:
4 years, 11 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add build_protobuf variable. This makes it possible to use protobuffers with an external protobuf library instead of the one that comes with the WebRTC code. NOTRY=True Committed: https://crrev.com/292e192f17b5cf46a485cd497e92b6b11f492f7b Cr-Commit-Position: refs/heads/master@{#11236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M webrtc/build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/protoc.gypi View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 11 months ago (2016-01-13 10:36:39 UTC) #2
terelius
lgtm
4 years, 11 months ago (2016-01-13 10:50:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589433002/1
4 years, 11 months ago (2016-01-13 13:45:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 13:47:02 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 13:47:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/292e192f17b5cf46a485cd497e92b6b11f492f7b
Cr-Commit-Position: refs/heads/master@{#11236}

Powered by Google App Engine
This is Rietveld 408576698