Eliminate defines in talk/

Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle.gyp

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org

Committed: https://crrev.com/fcfc804e436502d49b2176fec1f40dce3585527f
Cr-Commit-Position: refs/heads/master@{#11254}

[kjellander_webrtc, 2016-01-13 16:59:02]

Description was changed from

==========
Eliminate non-prefixed platform defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.

BUG=webrtc:5420
==========

to

==========
Eliminate non-prefixed platform defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.

BUG=webrtc:5420
==========

[kjellander_webrtc, 2016-01-13 16:59:02]

kjellander@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[kjellander_webrtc, 2016-01-13 17:03:30]

Description was changed from

==========
Eliminate non-prefixed platform defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.

BUG=webrtc:5420
==========

to

==========
Eliminate non-prefixed platform defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.

When this is rolled into Chromium, we can also clean them up in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
==========

[kjellander_webrtc, 2016-01-13 17:23:25]

Description was changed from

==========
Eliminate non-prefixed platform defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.

When this is rolled into Chromium, we can also clean them up in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
==========

to

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
==========

[kjellander_webrtc, 2016-01-13 17:24:05]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-01-13 17:32:00]

Description was changed from

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
==========

to

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
==========

[kjellander_webrtc, 2016-01-13 17:52:22]

Please ignore the purple trybots, it was my alias for the compile-only bots that
was outdated.

[kjellander_webrtc, 2016-01-13 18:09:07]

On 2016/01/13 17:52:22, kjellander (webrtc) wrote:
> Please ignore the purple trybots, it was my alias for the compile-only bots
that
> was outdated.

... and I realize I need to run all tests of course. Doing that for PS#2 now.

[kjellander_webrtc, 2016-01-13 18:09:34]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 18:09:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588453005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588453005/40001

[commit-bot: I haz the power, 2016-01-13 18:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 18:11:20]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4469)
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/4463)

[pthatcher1, 2016-01-13 19:20:06]

lgtm

[kjellander_webrtc, 2016-01-13 19:37:20]

On 2016/01/13 19:20:06, pthatcher1 wrote:
> lgtm

I think it's good to go (I forgot iOS GN doesn't work yet). Will check tomorrow.

[kjellander_webrtc, 2016-01-14 10:43:48]

kjellander@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kjellander_webrtc, 2016-01-14 10:44:16]

+tommi for root owners.

I'm currently testing this with a Chromium checkout to ensure nothing breaks.

[tommi, 2016-01-14 12:50:09]

are the bot failures related?

[kjellander_webrtc, 2016-01-14 17:01:58]

On 2016/01/14 12:50:09, tommi-webrtc wrote:
> are the bot failures related?

PS#2 runs all the bots and PS#3 contains the fix for iOS (that failed in PS#2).
The iOS GN bots can be ignored since they've never been green (I triggered them
by mistake).

[kjellander_webrtc, 2016-01-14 18:53:58]

Description was changed from

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
==========

to

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
==========

[kjellander_webrtc, 2016-01-14 18:55:55]

Description was changed from

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
==========

to

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
==========

[kjellander_webrtc, 2016-01-14 18:59:52]

On 2016/01/14 17:01:58, kjellander (webrtc) wrote:
> On 2016/01/14 12:50:09, tommi-webrtc wrote:
> > are the bot failures related?
> 
> PS#2 runs all the bots and PS#3 contains the fix for iOS (that failed in
PS#2).
> The iOS GN bots can be ignored since they've never been green (I triggered
them
> by mistake).

My tests with a Chromium checkout are passing so I'm going to TBR tommi for the
webrtc/* changes (that are only comments) and see how this goes in the
chromium.webrtc.fyi waterfall (which is now finally green).

[kjellander_webrtc, 2016-01-14 18:59:56]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-01-14 18:59:56]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1588453005/#ps60001 (title:
"Excluding iOS from converted OSX defines")

[commit-bot: I haz the power, 2016-01-14 19:00:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588453005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588453005/60001

[commit-bot: I haz the power, 2016-01-14 19:01:12]

Description was changed from

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
==========

to

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
==========

[commit-bot: I haz the power, 2016-01-14 19:01:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-14 19:01:31]

Description was changed from

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
==========

to

==========
Eliminate defines in talk/

Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org

Committed: https://crrev.com/fcfc804e436502d49b2176fec1f40dce3585527f
Cr-Commit-Position: refs/heads/master@{#11254}
==========

[commit-bot: I haz the power, 2016-01-14 19:01:32]

Patchset 3 (id:??) landed as
https://crrev.com/fcfc804e436502d49b2176fec1f40dce3585527f
Cr-Commit-Position: refs/heads/master@{#11254}