Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1588083002: Remove assert which was incorrectly added to TcpPort::OnSentPacket. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tommi
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove assert which was incorrectly added to TcpPort::OnSentPacket. TBR=pthatcher@webrtc.org BUG=webrtc:4173 Committed: https://crrev.com/2734d77c952cfae75fa79fd0631cc34caec4f084 Cr-Commit-Position: refs/heads/master@{#11252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/p2p/base/tcpport.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588083002/1
4 years, 11 months ago (2016-01-14 15:40:56 UTC) #2
stefan-webrtc
4 years, 11 months ago (2016-01-14 15:48:04 UTC) #5
stefan-webrtc
4 years, 11 months ago (2016-01-14 15:48:19 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2734d77c952cfae75fa79fd0631cc34caec4f084 Cr-Commit-Position: refs/heads/master@{#11252}
4 years, 11 months ago (2016-01-14 16:04:10 UTC) #9
stefan-webrtc
4 years, 11 months ago (2016-01-14 16:04:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2734d77c952cfae75fa79fd0631cc34caec4f084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698