webrtc/media/base/mediacommon.h - Issue 1587193006: Move talk/media to webrtc/media

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/media/base/mediacommon.h

Issue 1587193006: Move talk/media to webrtc/media (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Disable sign-compare warning on Win Clang Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.	2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #ifndef WEBRTC_P2P_BASE_SESSIONID_H_	11 #ifndef WEBRTC_MEDIA_BASE_MEDIACOMMON_H_

12 #define WEBRTC_P2P_BASE_SESSIONID_H_	12 #define WEBRTC_MEDIA_BASE_MEDIACOMMON_H_

13	13

14 // TODO: Remove this file.	14 #include "webrtc/base/stringencode.h"

15	15

16 namespace cricket {	16 namespace cricket {

17	17

	18 enum MediaCapabilities {

	19 AUDIO_RECV = 1 << 0,

	20 AUDIO_SEND = 1 << 1,

	21 VIDEO_RECV = 1 << 2,

	22 VIDEO_SEND = 1 << 3,

	23 };
	pthatcher1 2016/01/27 01:34:09 This is never used anywhere, and the only referenc This is never used anywhere, and the only references to mediacommon.h are in the files you are moving/changing. Can we simply remove the file and all references to it? kjellander_webrtc 2016/02/04 21:52:10 Sure, but I still would like to do that in a separ Show quoted text On 2016/01/27 01:34:09, pthatcher1 wrote: > This is never used anywhere, and the only references to mediacommon.h are in the > files you are moving/changing. Can we simply remove the file and all references > to it? Sure, but I still would like to do that in a separate CL. I'll add it to my TODO for this effort.
	24

18 } // namespace cricket	25 } // namespace cricket

19	26

20 #endif // WEBRTC_P2P_BASE_SESSIONID_H_	27 #endif // WEBRTC_MEDIA_BASE_MEDIACOMMON_H_

OLD	NEW

« webrtc/media/base/cryptoparams.h ('K') | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/base/mediaengine.h » ('j') | webrtc/media/base/mutedvideocapturer.cc » ('J')