Delete remnants of non-square pixel support from cricket::VideoFrame.

Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426
Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}

Committed: https://crrev.com/8b1e431231eea401afbe27cacccff7d127e3897c
Cr-Commit-Position: refs/heads/master@{#11287}

[nisse-webrtc, 2016-01-13 11:26:16]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org, pthatcher@webrtc.org

[nisse-webrtc, 2016-01-13 11:26:21]

I've checked for usage in chrome, and I've deleted those I have found. (cl
https://codereview.chromium.org/1588493002/)

[nisse-webrtc, 2016-01-13 11:30:11]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 11:30:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586613002/1

[commit-bot: I haz the power, 2016-01-13 12:56:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 12:56:00]

Dry run: This issue passed the CQ dry run.

[pthatcher1, 2016-01-13 16:44:30]

lgtm

[perkj_webrtc, 2016-01-13 19:39:43]

lgtm

[nisse-webrtc, 2016-01-14 07:42:53]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-01-14 07:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586613002/1

[commit-bot: I haz the power, 2016-01-14 07:43:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-14 07:44:06]

Description was changed from

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426
==========

to

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}
==========

[commit-bot: I haz the power, 2016-01-14 07:44:07]

Patchset 1 (id:??) landed as
https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}

[nisse-webrtc, 2016-01-14 10:34:58]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1583223002/ by nisse@webrtc.org.

The reason for reverting is: These changes broke chrome.

Need to temporarily keep methods InitToEmptyBuffer, InitToBlack,
CreateEmptyFrame with old but ignored arguments for pixel_width and
pixel_height. Then update chrome, and delete the old methods in a separate cl.
.

[nisse-webrtc, 2016-01-14 11:00:11]

Description was changed from

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}
==========

to

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}
==========

[nisse-webrtc, 2016-01-14 11:57:54]

Hi, would you mind having a second look before I try to re-land this? It turned
I had missed two places in chrome where it calls InitToBlack and
InitToEmptyBuffer, two methods where I deleted the pixel_width and pixel_height
arguments.

And maybe the wrapper methods should be non-virtual, or even final?

[pthatcher1, 2016-01-14 19:12:50]

LGTM (again)

[nisse-webrtc, 2016-01-18 08:18:55]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-01-18 08:18:55]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1586613002/#ps20001 (title:
"Keep old InitToBlack and InitToEmptyBuffer methods.")

[commit-bot: I haz the power, 2016-01-18 08:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586613002/20001

[commit-bot: I haz the power, 2016-01-18 09:46:32]

Description was changed from

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}
==========

to

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}
==========

[commit-bot: I haz the power, 2016-01-18 09:46:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-18 09:46:39]

Description was changed from

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}
==========

to

==========
Delete remnants of non-square pixel support from cricket::VideoFrame.

If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}

Committed: https://crrev.com/8b1e431231eea401afbe27cacccff7d127e3897c
Cr-Commit-Position: refs/heads/master@{#11287}
==========

[commit-bot: I haz the power, 2016-01-18 09:46:40]

Patchset 2 (id:??) landed as
https://crrev.com/8b1e431231eea401afbe27cacccff7d127e3897c
Cr-Commit-Position: refs/heads/master@{#11287}