Fixed sending Rtp packets with non zero csrcs and certain extensions.

Fixed sending Rtp packets with non zero csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org

Committed: https://crrev.com/d9e62f58371d1bcafc94edfa1eed836d90627bfe
Cr-Commit-Position: refs/heads/master@{#11258}

[danilchap, 2016-01-13 14:46:32]

Description was changed from

==========
Fixed sending Rtp packets with csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

to

==========
Fixed sending Rtp packets with csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

[danilchap, 2016-01-13 15:04:05]

Description was changed from

==========
Fixed sending Rtp packets with csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

to

==========
Fixed sending Rtp packets with non zero csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

[danilchap, 2016-01-13 15:12:55]

Five extensions are affected:
TransmissionTimeOffset
AudioLevel
VideoRotation
AbsoluteSendTime
TransportSequenceNumber

most of the time bug prevents to set value in the extension.
With carefully crafted csrcs it may be possible to damage sended csrcs or
extension header.

[stefan-webrtc, 2016-01-14 14:59:17]

https://codereview.webrtc.org/1586523003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/1586523003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:151: uint8_t
number_of_csrcs = 0) {
No default values please, instead pass in all arguments, or create two
functions.

https://codereview.webrtc.org/1586523003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:558:
rtp_sender_->SetCsrcs(csrcs);
Shouldn't you use at least 2 CSRCs to trigger this bug?

[danilchap, 2016-01-14 15:45:04]

https://codereview.webrtc.org/1586523003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/1586523003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:151: uint8_t
number_of_csrcs = 0) {
On 2016/01/14 14:59:17, stefan-webrtc (holmer) wrote:
> No default values please, instead pass in all arguments, or create two
> functions.

Done.

https://codereview.webrtc.org/1586523003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:558:
rtp_sender_->SetCsrcs(csrcs);
On 2016/01/14 14:59:17, stefan-webrtc (holmer) wrote:
> Shouldn't you use at least 2 CSRCs to trigger this bug?

No, one is enough. I checked test was red before creating the fix.

[stefan-webrtc, 2016-01-14 17:26:54]

lgtm

[danilchap, 2016-01-14 18:57:32]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-01-14 18:57:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586523003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586523003/60001

[commit-bot: I haz the power, 2016-01-14 19:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 19:40:30]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[danilchap, 2016-01-14 22:14:03]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-01-14 22:14:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586523003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586523003/60001

[commit-bot: I haz the power, 2016-01-14 22:55:21]

Description was changed from

==========
Fixed sending Rtp packets with non zero csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

to

==========
Fixed sending Rtp packets with non zero csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

[commit-bot: I haz the power, 2016-01-14 22:55:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-14 22:55:29]

Description was changed from

==========
Fixed sending Rtp packets with non zero csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org
==========

to

==========
Fixed sending Rtp packets with non zero csrcs and certain extensions.
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org

Committed: https://crrev.com/d9e62f58371d1bcafc94edfa1eed836d90627bfe
Cr-Commit-Position: refs/heads/master@{#11258}
==========

[commit-bot: I haz the power, 2016-01-14 22:55:30]

Patchset 4 (id:??) landed as
https://crrev.com/d9e62f58371d1bcafc94edfa1eed836d90627bfe
Cr-Commit-Position: refs/heads/master@{#11258}