Fix expectation bug in the RTPSender unit test.

Fix expectation bug in the RTPSender unit test.

The current expectation for InsertPacket(...) uses WillRepeatedly, which accepts if the function is called zero or more times. This CL changes this to either a fixed number of calls, or at least a positive number of calls.

Committed: https://crrev.com/5d332ac8ffc1ff8efb35abd12b913ec495873494
Cr-Commit-Position: refs/heads/master@{#11256}

[terelius, 2016-01-14 14:57:55]

terelius@webrtc.org changed reviewers:
+ stefan@webrtc.org

[terelius, 2016-01-14 14:57:55]

This CL makes sure the InsertPacket is called from the RTPSender.

[stefan-webrtc, 2016-01-14 15:03:42]

https://codereview.webrtc.org/1585783003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/1585783003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:629:
.WillOnce(testing::Return());
I _think_ you don't need this if the method is void?

[terelius, 2016-01-14 15:41:01]

https://codereview.webrtc.org/1585783003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/1585783003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:629:
.WillOnce(testing::Return());
On 2016/01/14 15:03:42, stefan-webrtc (holmer) wrote:
> I _think_ you don't need this if the method is void?

You're right. Done.

[stefan-webrtc, 2016-01-14 18:53:00]

lgtm

[terelius, 2016-01-14 21:02:38]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-01-14 21:02:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585783003/20001

[commit-bot: I haz the power, 2016-01-14 22:37:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 22:37:51]

Description was changed from

==========
Fix expectation bug in the RTPSender unit test.

The current expectation for InsertPacket(...) uses WillRepeatedly, which accepts
if the function is called zero or more times. This CL changes this to either a
fixed number of calls, or at least a positive number of calls.
==========

to

==========
Fix expectation bug in the RTPSender unit test.

The current expectation for InsertPacket(...) uses WillRepeatedly, which accepts
if the function is called zero or more times. This CL changes this to either a
fixed number of calls, or at least a positive number of calls.

Committed: https://crrev.com/5d332ac8ffc1ff8efb35abd12b913ec495873494
Cr-Commit-Position: refs/heads/master@{#11256}
==========

[commit-bot: I haz the power, 2016-01-14 22:37:52]

Patchset 2 (id:??) landed as
https://crrev.com/5d332ac8ffc1ff8efb35abd12b913ec495873494
Cr-Commit-Position: refs/heads/master@{#11256}