Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1583773006: Remove fakewebrtccommon.h. (Closed)

Created:
4 years, 11 months ago by the sun
Modified:
4 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@wvoe_apm
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove fakewebrtccommon.h. BUG=webrtc:4690 Committed: https://crrev.com/f7a5335ca5f154100a479d2feeef1c465e159bd0 Cr-Commit-Position: refs/heads/master@{#13993}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : rebase #

Patch Set 4 : removed include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -46 lines) Patch
M webrtc/media/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/media/engine/fakewebrtccommon.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 2 3 2 chunks +19 lines, -2 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
the sun
4 years, 11 months ago (2016-01-14 14:46:24 UTC) #2
tommi
lgtm
4 years, 11 months ago (2016-01-14 15:43:34 UTC) #3
the sun
FYI, I rebased this old CL and thought I'd land it now.
4 years, 3 months ago (2016-08-31 10:28:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/1583773006/60001
4 years, 3 months ago (2016-08-31 12:07:32 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-31 12:18:26 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 12:18:35 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f7a5335ca5f154100a479d2feeef1c465e159bd0
Cr-Commit-Position: refs/heads/master@{#13993}

Powered by Google App Engine
This is Rietveld 408576698