Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1583223002: Revert of Delete remnants of non-square pixel support from cricket::VideoFrame. (Closed)

Created:
4 years, 11 months ago by nisse-webrtc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete remnants of non-square pixel support from cricket::VideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/1586613002/ ) Reason for revert: These changes broke chrome. Need to temporarily keep methods InitToEmptyBuffer, InitToBlack, CreateEmptyFrame with old but ignored arguments for pixel_width and pixel_height. Then update chrome, and delete the old methods in a separate cl. Original issue's description: > Delete remnants of non-square pixel support from cricket::VideoFrame. > > If ever needed, add some aspect ratio parameter, without pixel_width > and pixel_height arguments cluttering commonly used functions. > > BUG=webrtc:5426 > > Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25 > Cr-Commit-Position: refs/heads/master@{#11243} TBR=pthatcher@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/268493a96b93d6a11a595b3272c5a4cd7a1fdc47 Cr-Commit-Position: refs/heads/master@{#11246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -37 lines) Patch
M talk/app/webrtc/videotrack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/videoframe.h View 4 chunks +11 lines, -2 lines 0 comments Download
M talk/media/base/videoframe.cc View 1 chunk +1 line, -0 lines 0 comments Download
M talk/media/base/videoframe_unittest.h View 19 chunks +26 lines, -20 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe.h View 4 chunks +14 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe.cc View 9 chunks +24 lines, -10 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe_unittest.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
nisse-webrtc
Created Revert of Delete remnants of non-square pixel support from cricket::VideoFrame.
4 years, 11 months ago (2016-01-14 10:34:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583223002/1
4 years, 11 months ago (2016-01-14 10:35:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 10:35:27 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 10:35:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/268493a96b93d6a11a595b3272c5a4cd7a1fdc47
Cr-Commit-Position: refs/heads/master@{#11246}

Powered by Google App Engine
This is Rietveld 408576698