Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1582833002: Add ramp-up tests for transport sequence number with and w/o audio. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add ramp-up tests for transport sequence number with and w/o audio. Also add a perf metric tracking the average network latency. The audio stream test is disabled for now since audio isn't included in bitrate allocation. BUG=webrtc:5263 R=mflodman@webrtc.org Committed: https://crrev.com/ff2a6351e0ad81ef8123c368fc17eeab40e66c71 Cr-Commit-Position: refs/heads/master@{#11244}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed. #

Patch Set 3 : Fixed compile issues. #

Patch Set 4 : Fix win compile issue... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -11 lines) Patch
M webrtc/call/rampup_tests.h View 3 chunks +6 lines, -1 line 0 comments Download
M webrtc/call/rampup_tests.cc View 1 2 9 chunks +85 lines, -8 lines 0 comments Download
M webrtc/test/direct_transport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/direct_transport.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/test/fake_network_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_network_pipe.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (13 generated)
stefan-webrtc
4 years, 11 months ago (2016-01-13 14:28:55 UTC) #3
mflodman
One comment, then LGTM. https://codereview.webrtc.org/1582833002/diff/1/webrtc/call/rampup_tests.cc File webrtc/call/rampup_tests.cc (right): https://codereview.webrtc.org/1582833002/diff/1/webrtc/call/rampup_tests.cc#newcode203 webrtc/call/rampup_tests.cc:203: size_t i = 0; Not ...
4 years, 11 months ago (2016-01-13 15:12:45 UTC) #4
stefan-webrtc
https://codereview.webrtc.org/1582833002/diff/1/webrtc/call/rampup_tests.cc File webrtc/call/rampup_tests.cc (right): https://codereview.webrtc.org/1582833002/diff/1/webrtc/call/rampup_tests.cc#newcode203 webrtc/call/rampup_tests.cc:203: size_t i = 0; On 2016/01/13 15:12:45, mflodman wrote: ...
4 years, 11 months ago (2016-01-13 16:23:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582833002/20001
4 years, 11 months ago (2016-01-13 16:25:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4464) ios_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 11 months ago (2016-01-13 16:28:28 UTC) #10
stefan-webrtc
Fixed compile issues.
4 years, 11 months ago (2016-01-13 17:28:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582833002/40001
4 years, 11 months ago (2016-01-13 17:29:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/11832)
4 years, 11 months ago (2016-01-13 17:50:15 UTC) #16
stefan-webrtc
Fix win compile issue...
4 years, 11 months ago (2016-01-13 18:04:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582833002/60001
4 years, 11 months ago (2016-01-13 18:04:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/312)
4 years, 11 months ago (2016-01-13 19:16:39 UTC) #22
stefan-webrtc
Committed patchset #4 (id:60001) manually as ff2a6351e0ad81ef8123c368fc17eeab40e66c71 (presubmit successful).
4 years, 11 months ago (2016-01-14 09:00:42 UTC) #24
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 09:00:44 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ff2a6351e0ad81ef8123c368fc17eeab40e66c71
Cr-Commit-Position: refs/heads/master@{#11244}

Powered by Google App Engine
This is Rietveld 408576698