Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 1582503002: [rtp_rtcp] rtcp::Empty moved into own file and renamed to CompoundPacket on the way (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] rtcp::Empty moved into own file and renamed to CompoundPacket on the way Class renamed to indicated use of the rtcp::Empty class: it can only be used as container for other rtcp packets. All tests that use Append function moved from rtcp_packet_unittest, even if they did not use Empty class. This is because there is plan to make RtcpPacket class lighter by moving Append functionality to CompoundPacket class. BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/2f7dea164dc49ae8a0322e3c9edb1dd23266c664 Cr-Commit-Position: refs/heads/master@{#11234}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -157 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 chunk +0 lines, -11 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet.h View 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet.cc View 1 chunk +28 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc View 1 1 chunk +157 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 3 chunks +0 lines, -126 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
åsapersson
lgtm https://codereview.webrtc.org/1582503002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc (right): https://codereview.webrtc.org/1582503002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc#newcode10 webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc:10: * This file includes unit tests for the ...
4 years, 11 months ago (2016-01-12 13:07:19 UTC) #1
danilchap
https://codereview.webrtc.org/1582503002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc (right): https://codereview.webrtc.org/1582503002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc#newcode10 webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc:10: * This file includes unit tests for the RtcpPacket. ...
4 years, 11 months ago (2016-01-12 13:20:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582503002/20001
4 years, 11 months ago (2016-01-13 09:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-13 10:03:08 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 10:03:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f7dea164dc49ae8a0322e3c9edb1dd23266c664
Cr-Commit-Position: refs/heads/master@{#11234}

Powered by Google App Engine
This is Rietveld 408576698