Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1582493002: Delete unused method webrtc::VideoRendererInterface::SetSize. (Closed)

Created:
4 years, 11 months ago by nisse-webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused method webrtc::VideoRendererInterface::SetSize. BUG=webrtc:5426 Committed: https://crrev.com/3e1cfa7edba8081faada275683b3d1fc71f37ac7 Cr-Commit-Position: refs/heads/master@{#11223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M talk/app/webrtc/mediastreaminterface.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nisse-webrtc
I's not crystal clear to me whether or not this is considered a change to ...
4 years, 11 months ago (2016-01-12 10:43:50 UTC) #2
perkj_webrtc
lgtm Please add a BUG number to track the capture cleanup effort and in that ...
4 years, 11 months ago (2016-01-12 10:48:18 UTC) #3
tommi
lgtm
4 years, 11 months ago (2016-01-12 11:20:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582493002/1
4 years, 11 months ago (2016-01-12 12:02:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 14:39:24 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 14:39:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e1cfa7edba8081faada275683b3d1fc71f37ac7
Cr-Commit-Position: refs/heads/master@{#11223}

Powered by Google App Engine
This is Rietveld 408576698