Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: webrtc/base/ratetracker_unittest.cc

Issue 1582333008: Let a minimum time interval pass (one bucket size) after initialization before reporting rates (to … (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: add unittest Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/ratetracker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/ratetracker_unittest.cc
diff --git a/webrtc/base/ratetracker_unittest.cc b/webrtc/base/ratetracker_unittest.cc
index 2187282cd3fd406b6118abe2c9a5bd09bda82cee..75fec55818826fbc45a113ea529bedf6a30d7f82 100644
--- a/webrtc/base/ratetracker_unittest.cc
+++ b/webrtc/base/ratetracker_unittest.cc
@@ -12,10 +12,13 @@
#include "webrtc/base/ratetracker.h"
namespace rtc {
+namespace {
+ const uint32_t kBucketIntervalMs = 100;
+} // namespace
class RateTrackerForTest : public RateTracker {
public:
- RateTrackerForTest() : RateTracker(100u, 10u), time_(0) {}
+ RateTrackerForTest() : RateTracker(kBucketIntervalMs, 10u), time_(0) {}
virtual uint32_t Time() const { return time_; }
void AdvanceTime(uint32_t delta) { time_ += delta; }
@@ -55,8 +58,11 @@ TEST(RateTrackerTest, TestRateTrackerBasics) {
// Add a sample.
tracker.AddSamples(1234);
- // Advance the clock by 100 ms.
- tracker.AdvanceTime(100);
+ // Advance the clock by less than one bucket interval (no rate returned).
+ tracker.AdvanceTime(kBucketIntervalMs - 1);
+ EXPECT_DOUBLE_EQ(0.0, tracker.ComputeRate());
+ // Advance the clock by 100 ms (one bucket interval).
+ tracker.AdvanceTime(1);
EXPECT_DOUBLE_EQ(12340.0, tracker.ComputeRateForInterval(1000u));
EXPECT_DOUBLE_EQ(12340.0, tracker.ComputeRate());
EXPECT_EQ(1234U, tracker.TotalSampleCount());
« no previous file with comments | « webrtc/base/ratetracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698